Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add option for user-provided URL in synthesize #82

Merged
merged 2 commits into from
Aug 16, 2018
Merged

Conversation

dpopp07
Copy link
Contributor

@dpopp07 dpopp07 commented Aug 16, 2018

Added an option for user to provide their own URL everywhere it seemed appropriate:

  • text-to-speech/synthesize
  • text-to-speech/getVoices
  • speech-to-text/getModels

Updated the JSDocs and README.

@germanattanasio
Copy link
Contributor

Can we use string concatenation?

@dpopp07
Copy link
Contributor Author

dpopp07 commented Aug 16, 2018

Yes, we can! Updated

@dpopp07 dpopp07 merged commit 6b8f2ba into master Aug 16, 2018
@dpopp07 dpopp07 deleted the allow-user-url branch August 16, 2018 21:00
@watson-github-bot
Copy link
Member

🎉 This PR is included in version 0.35.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants