Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull request #82 ships code incompatible with some browsers #88

Closed
vpicone opened this issue Sep 6, 2018 · 2 comments
Closed

Pull request #82 ships code incompatible with some browsers #88

vpicone opened this issue Sep 6, 2018 · 2 comments

Comments

@vpicone
Copy link

vpicone commented Sep 6, 2018

#82 uses template literals which aren't supported in ie 11. Regular string concatenation should be used or the code should be compiled to es5 before being shipped.

This was discovered when my build script failed due to es6 code being discovered in one of my deps.

@vpicone
Copy link
Author

vpicone commented Sep 6, 2018

Creating an optimized production build...
Failed to compile.

Failed to minify the code from this file:

        ./node_modules/watson-speech/speech-to-text/get-models.js:57

Read more here: http://bit.ly/2tRViJ9

relevant info from the link:

Some third-party packages don't compile their code to ES5 before publishing to npm. This often causes problems in the ecosystem because neither browsers (except for most modern versions) nor some tools currently support all ES6 features. We recommend to publish code on npm as ES5 at least for a few more years.

This also happens in a few other locations touched by #82, once it's fixed in one the error crops up in the others.

@dpopp07
Copy link
Contributor

dpopp07 commented Sep 10, 2018

Thanks for letting us know, I opened #89 to resolve.

@dpopp07 dpopp07 closed this as completed Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants