Update example apps to account for recent changes #809
Conversation
Co-authored-by: Shayne Czyzewski <[email protected]>
Co-authored-by: Martin Šošić <[email protected]>
…into filip-js-go-to-definition
…into filip-js-go-to-definition
There was a problem hiding this comment.
Looking good @sodic! Tried running a few, all seems good. Nice work refactoring all of them. Left a few comments/questions 👍🏻 I wonder if, given your updates here, if in the ChangeLog update describing this we can give a TL;DR update of what they can do to refactor their apps? I know it is pretty straightforward but may help some if we list it out.
| @@ -40,7 +40,7 @@ watch waspProjectDir outDir ongoingCompilationResultMVar = FSN.withManager $ \mg | |||
| currentTime <- getCurrentTime | |||
| chan <- newChan | |||
| _ <- FSN.watchDirChan mgr (SP.fromAbsDir waspProjectDir) eventFilter chan | |||
| let watchProjectSubdirTree path = FSN.watchDirChan mgr (SP.fromAbsDir $ waspProjectDir </> path) eventFilter chan | |||
| let watchProjectSubdirTree path = FSN.watchTreeChan mgr (SP.fromAbsDir $ waspProjectDir </> path) eventFilter chan | |||
There was a problem hiding this comment.
Is this change supposed to be in this PR?
waspc/run
Outdated
| @@ -24,7 +24,7 @@ TEST_CMD="cabal test" | |||
| TEST_UNIT_CMD="cabal test waspc-test" | |||
| TEST_CLI_CMD="cabal test cli-test" | |||
| TEST_E2E_CMD="cabal test e2e-test" | |||
| TEST_E2E_DELETE_GOLDENS="rm -r $PROJECT_ROOT/e2e-test/test-outputs/*-golden" | |||
| TEST_E2E_DELETE_GOLDENS="rm -rf $PROJECT_ROOT/e2e-test/test-outputs/*-golden" | |||
There was a problem hiding this comment.
This change may be old (i.e. already merged) now too.
waspc/new-release
Outdated
| let newContents = beforeMatch ++ matchBeforeVersion ++ newVersion ++ afterMatch | ||
| return (newContents, oldVersion) | ||
| let (beforeMatch, match, afterMatch, submatches) = | ||
| cabalFileContents TR.=~ ("^(version: *)([0-9]+\\.[0-9]+\\.[0-9]+)" :: String) :: (String, String, String, [String]) |
There was a problem hiding this comment.
Looks like on this line we lost an \\.[0-9]+ at the end. Was that intended?
examples/thoughts/.env.server
Outdated
| @@ -0,0 +1 @@ | |||
| DATABASE_URL=postgresql://postgres:devpass1234@localhost:5432/thoughts-dev | |||
There was a problem hiding this comment.
We may want to remove this file entirely since it is .gitignore'd and the only env file we have committed for examples.
There was a problem hiding this comment.
Yeah, thought so too. I can remove it.
…ples-new-structure
… into filip-update-docs-new-structure
|
@shayneczyzewski Thanks for the review, three of your comments should be resolved now, I forgot to push a base branch merge (as you guessed, these changes are already in main).
Good idea, I'll do that! |
| @@ -1,5 +0,0 @@ | |||
| -- CreateTable | |||
| CREATE TABLE "Excuse" ( | |||
There was a problem hiding this comment.
This file was causing DB errors. We have two init migrations, this was the one that was out of date. I kept the other one.
|
@shayneczyzewski Addressed all your comments and added the migration guide to the changelog. I think this is it. Note: I didn't update this page: https://wasp-lang.dev/blog/2021/03/02/wasp-alpha. It's pretty old and hasn't been updated in ages (e.g., it uses Wasp syntax I've never seen). Everything else should be taken care of. |
There was a problem hiding this comment.
Awesome job @sodic! Found one minor typo but all this looks great. Love the Changelog update! 🚀 great job getting all these examples up to date 👍🏻
| ``` | ||
| Do this for all external imports in your `.wasp` file. After you're done, there shouldn't be any occurences of the string `"@ext"`. | ||
|
|
||
| That's it! You should now have a fully working Wasp project in the `foo` directory. |
There was a problem hiding this comment.
Awesome guide!!! 🥳
There was a problem hiding this comment.
Thanks, I accumulated a lot of experience with this in recent days :)
Co-authored-by: Shayne Czyzewski <[email protected]>
Co-authored-by: Shayne Czyzewski <[email protected]>
Co-authored-by: Shayne Czyzewski <[email protected]>
… into filip-update-docs-new-structure
… into filip-update-examples-new-structure
Updates the example apps with recent changes to the project structure and environment variable definitions. PRs covered by this: