Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update example styling #807

Merged
merged 4 commits into from
Nov 16, 2022
Merged

Update example styling #807

merged 4 commits into from
Nov 16, 2022

Conversation

shayneczyzewski
Copy link
Contributor

@shayneczyzewski shayneczyzewski commented Nov 8, 2022 •
edited
Loading

Description

This tidies up examples, to include:

  • adding default styles that were removed (where applicable) [Tailwind change]

The other changes in here were removed and added by Filip's PR: #809

Type of change

Please select the option(s) that is more relevant.

  • Code cleanup
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

@shayneczyzewski shayneczyzewski changed the title TIP: Tidy up examples WIP: Tidy up examples Nov 8, 2022
@shayneczyzewski
Copy link
Contributor Author

TODO: rebase and remove things Filip did already

@shayneczyzewski shayneczyzewski changed the title WIP: Tidy up examples Update example styling Nov 14, 2022
@shayneczyzewski shayneczyzewski marked this pull request as ready for review November 14, 2022 17:37
matijaSos
matijaSos approved these changes Nov 14, 2022
View reviewed changes
Copy link
Contributor

@matijaSos matijaSos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@shayneczyzewski shayneczyzewski merged commit c71c810 into main Nov 16, 2022
@shayneczyzewski shayneczyzewski deleted the shayne-tidy-up-examples branch November 16, 2022 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sodic sodic sodic approved these changes

@matijaSos matijaSos matijaSos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shayneczyzewski @matijaSos @sodic