Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates SDK tsconfig to enable the incremental #1931

Merged
merged 6 commits into from
Apr 3, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions waspc/ChangeLog.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,16 @@
# Changelog

## 0.13.1 (2024-04-04)

### 🐞 Bug fixes

- Vite HMR now works correctly with Wasp's new project structure (no more full-page reloads).
- Keycloak UI helpers are now correctly exported.

### 🔧 Small improvements

- Improved how IDEs auto-import symbols from `wasp/*` modules.

## 0.13.0 (2024-03-18)

### ⚠️ Breaking changes
Expand Down
5 changes: 5 additions & 0 deletions waspc/data/Generator/templates/sdk/wasp/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,11 @@
// about missing types e.g. when using `toBeInTheDocument` and other matchers.
"@testing-library/jest-dom"
],
// This option enables faster SDK compilation, less Vite HMR messages
// and it prevent unnecessary full-page reloads when using Vite HMR.
// While this is great, we still want to dig deeper at some point to understand
// better why Vite HMR misbehaves when the SDK is recompiled: https://github.com/wasp-lang/wasp/issues/1934
"incremental": true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find!

Wondering why this isn't the default option 🤔

// todo(filip): Only works with common js, see https://www.typescriptlang.org/tsconfig#paths and daily-article.
// "paths": {
// "@wasp/*": [
Expand Down
3 changes: 2 additions & 1 deletion waspc/e2e-test/GoldenTest.hs
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,8 @@ runGoldenTest goldenTest = do
"dev.db-journal",
"package-lock.json",
".gitignore",
".DS_Store"
".DS_Store",
"tsconfig.tsbuildinfo"
Copy link
Contributor Author

@infomiho infomiho Apr 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a internal file written by TSC when using the incremental option. There is no need to keep track of the changes to that file IMHO

]

writeFileManifest :: String -> [FilePath] -> FilePath -> IO ()
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading