Updates SDK tsconfig to enable the incremental
#1931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mihovil Ilakovac <[email protected]>
Signed-off-by: Mihovil Ilakovac <[email protected]>
infomiho
commented
Apr 2, 2024
| @@ -96,7 +96,8 @@ runGoldenTest goldenTest = do | |||
| "dev.db-journal", | |||
| "package-lock.json", | |||
| ".gitignore", | |||
| ".DS_Store" | |||
| ".DS_Store", | |||
| "tsconfig.tsbuildinfo" | |||
There was a problem hiding this comment.
It's a internal file written by TSC when using the incremental option. There is no need to keep track of the changes to that file IMHO
Closed
sodic
approved these changes
Apr 3, 2024
| @@ -28,6 +28,7 @@ | |||
| // about missing types e.g. when using `toBeInTheDocument` and other matchers. | |||
| "@testing-library/jest-dom" | |||
| ], | |||
| "incremental": true, | |||
There was a problem hiding this comment.
Great find!
Wondering why this isn't the default option 🤔
Signed-off-by: Mihovil Ilakovac <[email protected]>
Signed-off-by: Mihovil Ilakovac <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had an issue with Vite hot module reload (HMR) not working properly: the HRM would happen, React would keep the state and it seemed good. But then the SDK would be rebuilt, trigger full-page reload, losing the React state. This completely defeats the purpose of HMR!
Adding
incremental: truehelps with Vite HMR working properly. The SDK wouldn't be rebuilt unless necessary and wouldn't trigger full-page related ✅This also has some nice side-effects:
Closes #1829