Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove client file hacks from server/tsconfig.json #1862

Merged
merged 2 commits into from
Mar 11, 2024
Merged

Remove client file hacks from server/tsconfig.json #1862

merged 2 commits into from
Mar 11, 2024

Conversation

sodic
Copy link
Contributor

@sodic sodic commented Mar 7, 2024

Closes #1855.

@sodic sodic mentioned this pull request Mar 7, 2024
Closed
infomiho
infomiho approved these changes Mar 8, 2024
View reviewed changes
Copy link
Contributor

@infomiho infomiho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Tested locally as well to be extra safe

@sodic sodic merged commit e87f904 into main Mar 11, 2024
6 checks passed
@sodic sodic deleted the filip-remove-client-hacks branch March 11, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infomiho infomiho infomiho approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate whether the server can work without client file hacks
2 participants
@sodic @infomiho