Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate whether the server can work without client file hacks #1855

Closed
sodic opened this issue Mar 5, 2024 · 1 comment · Fixed by #1862
Closed

Investigate whether the server can work without client file hacks #1855

sodic opened this issue Mar 5, 2024 · 1 comment · Fixed by #1862

Comments

@sodic
Copy link
Contributor

sodic commented Mar 5, 2024

Context: #1584 (comment)

Note

It makes sense to tackle this first: #1854

Can we remove the client-specific options in our server/tsconfig.json?

With the current setup, it depends on how typescript (or rollup) chooses which files to process:

  • If it's "by demand" (i.e., only process what you need), then we probably don't need the hacks.
  • If it's "by includes directories" (i.e., process all files in directories that are part of the project), then we probably need them.

I don't know which one is it, so we should investigate.

@sodic
Copy link
Contributor Author

sodic commented Mar 7, 2024

I've removed the client hacks. We don't seem to need them anymore: #1862.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant