Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit src/ directory structure #816

Closed
shayneczyzewski opened this issue Nov 14, 2022 · 6 comments
Closed

Revisit src/ directory structure #816

shayneczyzewski opened this issue Nov 14, 2022 · 6 comments
Assignees
Labels
discussion dx hm Requires more thought idea Something to consider major feature question Further information is requested research

Comments

@shayneczyzewski
Copy link
Contributor

We recently moved away from ext/ and @ext imports to src/client and @client imports (similar for server/shared). This helped with our dev tooling support, amongst other benefits. However, a few questions remain:

  • Would it be better to have client/server/shared at the top level and src under each? This would allow us to pull in things like tailwind.config.js under client (but not src), and Dockerfile under server.
  • In the existing or new world, where should the public/ dir live?

We can take inspiration from other projects, like Meteor here. @sodic has some insights and thoughts I will let him add as well.

@shayneczyzewski shayneczyzewski added question Further information is requested idea Something to consider hm Requires more thought research major feature discussion dx labels Nov 14, 2022
@Martinsos
Copy link
Member

Related to #9

@sodic
Copy link
Contributor

sodic commented Dec 8, 2022

Related to #811.

@Martinsos
Copy link
Member

Related to #734 .

@sodic
Copy link
Contributor

sodic commented Feb 29, 2024

This issue is no longer relevant with changes introduced released in Wasp 0.12.0 (merged in #1686 )

Server code and client code are mixed under src and all config files now reside at the top-level, as is the case with most popular frameworks.

Shayne, if you're reading this: Yes, we've gone full circle 😄

@sodic sodic closed this as completed Feb 29, 2024
@shayneczyzewski
Copy link
Contributor Author

shayneczyzewski commented Feb 29, 2024 via email

@Martinsos
Copy link
Member

Haha, love the comment at the end Filip! And I'm glad you all iterated on how best to do this. I really do like the new setup!

On Thu, Feb 29, 2024 at 11:53 AM Filip Sodić @.> wrote: This issue is no longer relevant with changes introduced released in Wasp 0.12.0. Server code and client code are mixed under src and all config files now reside at the top-level, as is the case with most popular frameworks. Shayne, if you're reading this: Yes, we've gone full circle 😄 — Reply to this email directly, view it on GitHub <#816 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAD725AHOJ7LOASBJ2E776TYV5VLHAVCNFSM6AAAAAAR76PWVGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZRGY2TSOBVGA . You are receiving this because you authored the thread.Message ID: @.>

Good old 360 turn :D!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion dx hm Requires more thought idea Something to consider major feature question Further information is requested research
Projects
None yet
Development

No branches or pull requests

3 participants