Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move environment variable files to src/server and src/client #811

Closed
sodic opened this issue Nov 11, 2022 · 1 comment
Closed

Move environment variable files to src/server and src/client #811

sodic opened this issue Nov 11, 2022 · 1 comment

Comments

@sodic
Copy link
Contributor

sodic commented Nov 11, 2022

After merging #753, we've separated the server code from the client code. However, the files .env.server and .env.client are still in the project's root directory.

We should move them to src/server and src/client respectively. Also, it might make sense to reconsider the name src, as it can contain more than just source files (e.g., images, .env files, documents...).

While we're at it, let's also make sure to warn users if they put them in the wrong place (as we currently do for .env).

@sodic sodic changed the title Move environment variables to src/server and src/client Move environment variable files to src/server and src/client Nov 11, 2022
@sodic sodic changed the title Move environment variable files to src/server and src/client Move environment variable files to src/server and src/client Jan 2, 2023
@sodic
Copy link
Contributor Author

sodic commented Feb 29, 2024

This issue is no longer relevant with changes introduced released in Wasp 0.12.0 (merged in #1686 )

Server code and client code are mixed under src and all config files now reside at the top-level, as is the case with most popular frameworks.

@sodic sodic closed this as completed Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants