Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix minor findings #1207

Merged
merged 8 commits into from
Sep 30, 2024
Merged

Fix minor findings #1207

merged 8 commits into from
Sep 30, 2024

Commits on Sep 30, 2024

  1. correctly spell [un]signed

    @Robbepop
    Robbepop committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    d692464 View commit details
    Browse the repository at this point in the history

  2. fix last_index comment 

    We maybe also want to rename the method.
    @Robbepop
    Robbepop committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    c3953c7 View commit details
    Browse the repository at this point in the history

  3. remove unused method

    @Robbepop
    Robbepop committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    d1f0afd View commit details
    Browse the repository at this point in the history

  4. re-order statments to match call and call_indirect

    @Robbepop
    Robbepop committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    1dc203f View commit details
    Browse the repository at this point in the history

  5. fix comment stating store instead of load

    @Robbepop
    Robbepop committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    034f621 View commit details
    Browse the repository at this point in the history

  6. re-instate panic for CompiledFuncEntity::new 

    Also added comment to state why this check exists.
    @Robbepop
    Robbepop committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    7b9f4aa View commit details
    Browse the repository at this point in the history

  7. remove invalid comment about panics 

    This function might return a BranchOffset of 0 for certain inputs.
    @Robbepop
    Robbepop committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    2c3bcbb View commit details
    Browse the repository at this point in the history

  8. get_compiled: conditionally panic if debug_assertions are enabled

    @Robbepop
    Robbepop committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    a68321d View commit details
    Browse the repository at this point in the history