Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor findings #1207

Merged
merged 8 commits into from
Sep 30, 2024
Merged

Fix minor findings #1207

merged 8 commits into from
Sep 30, 2024

Conversation

Robbepop
Copy link
Member

  • correctly spell [un]signed.
  • fix comment for last_index - we may also want to find a better name.
  • remove unused method adjust_for_call.
  • fix comment stating store instead of load.
  • re-instate panic for CompiledFuncEntity::new when there are more than i32::MAX instructions.
  • BranchOffset API: remove invalid comment about panics.
  • CodeMap::get_compiled: conditionally panic if debug_assertions are enabled.

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 81.35%. Comparing base (adedd6b) to head (a68321d).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/wasmi/src/engine/code_map.rs 33.33% 2 Missing ⚠️
crates/wasmi/src/engine/utils.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1207   +/-   ##
=======================================
  Coverage   81.35%   81.35%           
=======================================
  Files         302      303    +1     
  Lines       24953    24951    -2     
=======================================
  Hits        20300    20300           
+ Misses       4653     4651    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Robbepop Robbepop merged commit 39414e8 into main Sep 30, 2024
18 of 19 checks passed
@Robbepop Robbepop deleted the rf-minor-findings branch September 30, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant