wasmi_wasi: Update wasi-common and wiggle dependencies
#1140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it possible to remove the old and outdated `wasi-cap-std-sync` dependency altogether. Unfortunately with this update the `wasi-common` crate still pulls the huge `wasmtime` dependency into Wasmi and I am a bit confused why this happens. Issue: bytecodealliance/wasmtime#9009
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1140 +/- ##
==========================================
- Coverage 79.80% 79.74% -0.06%
==========================================
Files 296 296
Lines 25424 25426 +2
==========================================
- Hits 20289 20277 -12
- Misses 5135 5149 +14 ☔ View full report in Codecov by Sentry. |
|
Seems like the change to support Thus we have to wait for the 20th of next month to finally merge this PR and use the next |
Robbepop
force-pushed
the
rf-update-wasi-dependencies
branch
from
2f38c1a to
829dcff
Compare
|
I just made sure that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #943.
This makes it possible to remove the old and outdated
wasi-cap-std-syncdependency altogether.Unfortunately with this update the
wasi-commoncrate still pulls the hugewasmtimedependency into Wasmi and I am a bit confused why this happens.Issue: bytecodealliance/wasmtime#9009