-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wasi-common/sync
still introduces dependency on Wasmtime, but why?
#9009
Comments
This makes it possible to remove the old and outdated `wasi-cap-std-sync` dependency altogether. Unfortunately with this update the `wasi-common` crate still pulls the huge `wasmtime` dependency into Wasmi and I am a bit confused why this happens. Issue: bytecodealliance/wasmtime#9009
Here is a Wasmi PR with which you can reproduce the issue: wasmi-labs/wasmi#1140 |
According to https://docs.rs/crate/wasi-common/23.0.1/source/Cargo.toml.orig, #8900 is not yet included in wasi-common 23.0.x. Each release branches on the 5th of the month and gets released on the 20th: wasmtime/.github/workflows/release-process.yml Lines 23 to 24 in 5d0d616
|
Ah okay, that explains why I just successfully built So this means some more waiting before I can merge the Wasmi PR. Thanks for letting me know! This issue can be closed then. |
* update wasi-common and wiggle dependencies This makes it possible to remove the old and outdated `wasi-cap-std-sync` dependency altogether. Unfortunately with this update the `wasi-common` crate still pulls the huge `wasmtime` dependency into Wasmi and I am a bit confused why this happens. Issue: bytecodealliance/wasmtime#9009 * update wasi-common and wiggle dependencies
Recently we merged #8900 to remove the
wasmtime
optional dependency fromwasi-common/sync
since it was unused mostly.This had the effect that users could use
wasi-common
with itssync
feature without pulling in the giantic Wasmtime dependency ... or so I thought.Today I wanted to use
wasi-common
v23.0.1 (including this improvement) into Wasmi'swasmi_wasi
crate and to my surprise Cargo pulled Wasmtime via thewasi-common
dependency.When I removed the
sync
feature usage (which is kinda critical unfortunately) the Wasmtime dependency was gone.I am seriously confused as to why this happens. Looking at
wasi-common
'sCargo.toml
file does not help my confusion.https://github.com/bytecodealliance/wasmtime/blob/main/crates/wasi-common/Cargo.toml
Any help or clarification?
tl;dr:
This pulls Wasmtime:
And this does not:
But why?
The text was updated successfully, but these errors were encountered: