Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(modal): add onLeftClick prop to control left button event-handling #200

Merged
merged 1 commit into from
Feb 5, 2024
Merged

feat(modal): add onLeftClick prop to control left button event-handling #200

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/modal/src/component.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ export const Modal = ({
ccModal.titleButton,
ccModal.titleButtonLeft
)}
onClick={props.onDismiss}
onClick={props.onLeftClick ? props.onLeftClick : props.onDismiss}
>
<IconTableSortDown16
className={classNames(
Expand Down
5 changes: 5 additions & 0 deletions packages/modal/src/props.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,11 @@ export type ModalProps = {
*/
onDismiss?: () => void;

/**
* Handler that is called when the user clicks the left button
*/
onLeftClick?: () => void;

/**
* Defines a string value that labels the current element. Must be set if neither `aria-labelledby` or `<ModalHeading>` is defined,
*/
Expand Down
4 changes: 4 additions & 0 deletions packages/modal/stories/Modal.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,10 @@ export const WithBackAndCloseButton = () => {
left
right
onDismiss={toggleModal}
onLeftClick={() => {
console.log('left clicked');
toggleModal();
}}
title="Title of the content goes here"
footer={
<>
Expand Down
Loading