Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(modal): add onLeftClick prop to control left button event-handling #200

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

BalbinaK
Copy link
Contributor

@BalbinaK BalbinaK commented Feb 5, 2024

Fixes WARP-489

This will align Vue and React Modal's API, as well as solve a problem where it wasn't possible to reuse the default back button to go to the previous step in a multi-page Modal.

Copy link
Contributor

github-actions bot commented Feb 5, 2024

PR Preview Action v1.4.6
Preview removed because the pull request was closed.
2024-02-05 10:24 UTC

Copy link
Contributor

@felicia-haggqvist felicia-haggqvist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :)

@BalbinaK BalbinaK marked this pull request as ready for review February 5, 2024 09:24
@BalbinaK BalbinaK requested a review from imprashast February 5, 2024 09:54
@BalbinaK BalbinaK merged commit 96a750b into next Feb 5, 2024
3 checks passed
@BalbinaK BalbinaK deleted the feat/modal-left-click-handler branch February 5, 2024 10:23
github-actions bot pushed a commit that referenced this pull request Feb 5, 2024
# [1.4.0-next.1](v1.3.3-next.1...v1.4.0-next.1) (2024-02-05)

### Features

* **modal:** add onLeftClick prop to control left button event-handling ([#200](#200)) ([96a750b](96a750b))
github-actions bot pushed a commit that referenced this pull request Feb 5, 2024
# [1.4.0](v1.3.2...v1.4.0) (2024-02-05)

### Bug Fixes

* bump scroll-doctor lib to fix modal issue with scrollbars ([#199](#199)) ([e4bb6e9](e4bb6e9))

### Features

* **modal:** add onLeftClick prop to control left button event-handling ([#200](#200)) ([96a750b](96a750b))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants