feat: use identity credentials, and expose hash, bulk insert and delete members functions #58

richard-ramos · 2023-04-28T18:27:18Z

Requires:

feat(rln-wasm): expose hash, poseidon_hash and delete_leaf vacp2p/zerokit#148

richard-ramos · 2023-05-01T19:42:02Z

@rymnc,
While testing these changes, I wasnt able to generate/validate proofs with latest zerokit master. This commit vacp2p/zerokit@5eb98d4 ended being the culprit, because once I git revert it locally, my tests passed. I believe that there are some parts of the code that is using usize byte length instead of 8 bytes. I'll try to figure out tomorrow where that is happening.

Also, something slightly concerning is that executing all the test units is taking a lot of time. The whole test suite takes now 4 minutes.

Chrome Headless 101.0.4950.0 (Linux x86_64): Executed 13 of 13 SUCCESS (4 mins 13.007 secs / 4 mins 12.974 secs)

rymnc · 2023-05-02T03:55:07Z

@richard-ramos we could revert the offending commit. Are the tests slow with a working version of zerokit?

richard-ramos · 2023-05-02T18:22:10Z

@richard-ramos we could revert the offending commit. Are the tests slow with a working version of zerokit?

This PR vacp2p/zerokit#153 reverts the specific lines causing the issue. I'll try to identify which PR slows down the tests

richard-ramos · 2023-05-02T19:44:17Z

@rymnc,
The following commit introduce slowness into js-rln: vacp2p/zerokit@8cd4bab
it takes a single test from 3 seconds to ~23s

To test this out I did the following:

Checkout this PR, and execute npm install
In a terminal, execute the following, replacing the path in the last line by the location where js-rln was cloned

git clone https://github.com/vacp2p/zerokit
cd zerokit
git checkout 8cd4baba8ac73b0ef71e2fb6049409a8a349347f
git revert 5eb98d4b330e1107ed18c22856707110302263e4
cd rln-wasm
cargo make build
cp pkg/* /path/to/js-rln/node_modules/@waku/zerokit-rln-wasm/.

In the folder where js-rln is located npm run test

To speed up the testing process, you can remove all .spec.ts files except for index.spec.ts

…te members functions Also update the resources and karma.conf because proof generation is taking longer than usual

richard-ramos · 2023-05-04T14:54:35Z

This PR is ready for reviewing now! :)

weboko

Looks good, only thing is that we'll need to follow up by updating the example.

fryorcraken

Looks good.

fryorcraken · 2023-05-05T03:52:05Z

README.md

@@ -70,24 +70,24 @@ import * as rln from "@waku/rln";
 const rlnInstance = await rln.create();
 ```

-### Generating RLN Membership Keypair
+#### Generating RLN membership credentials


formatting nitpick

Suggested change

#### Generating RLN membership credentials

#### Generating RLN Membership Credentials

fryorcraken · 2023-05-05T03:52:44Z

example/index.js

@@ -1,7 +1,7 @@
 import * as rln from "@waku/rln";

 rln.create().then(async rlnInstance => {
-    let memKeys = rlnInstance.generateMembershipKey();
+    let credentials = rlnInstance.generateIdentityCredentials();


Suggested change

let credentials = rlnInstance.generateIdentityCredentials();

const credentials = rlnInstance.generateIdentityCredentials();

no?

Also, didn't you/we said we could remove this example? cc @weboko

That was on js-noise, although I think we can remove it here too?

Before we were talking about noise's example.
We can remove that one but I'd keep it since it helps to test changes in one repo.

fryorcraken · 2023-05-05T03:53:43Z

package.json

@@ -1,6 +1,6 @@
 {
  "name": "@waku/rln",
-  "version": "0.0.14",
+  "version": "0.1.0",


Big bump :)
Probably time to sort out automated release management?

Was thinking about it as well. I can duplicate from js-wakuto other repos or (just saying) we can move all waku libs to js-waku repo.

I think until we expect someone to use RLN in prod we leave it out. We can then reconsider when RLN is used beyond POCs

fryorcraken · 2023-05-05T03:55:04Z

src/rln.ts

      this.zkRLN,
      seedBytes
    );
-    return MembershipKey.fromBytes(memKeys);
+    return IdentityCredential.fromBytes(memKeys);


is there a difference between Identity Credentials and Credentials?

Originally MembershipKey only had IDKey and IDCommitment but in waku-org/nwaku#1466 this structure was renamed to IdentityCredential and added 2 new attributes to it (IDTrapdoor and IDNullifier) and renamed IDKey to IDSecretHash. For the sake of making it easier to compare js-rln with nwaku rln implementation I decided to rename it as well.

Since this is a breaking change I ended up creating a new minor version instead of just bumping up the revision

richard-ramos force-pushed the identity-credentials branch 2 times, most recently from 15c0794 to 2bc0ec2 Compare May 1, 2023 19:36

richard-ramos marked this pull request as ready for review May 1, 2023 19:37

richard-ramos requested review from rymnc and weboko May 1, 2023 19:42

feat: use identity credentials, and expose hash, bulk insert and dele…

f20bdbb

…te members functions Also update the resources and karma.conf because proof generation is taking longer than usual

richard-ramos force-pushed the identity-credentials branch from 2bc0ec2 to f20bdbb Compare May 4, 2023 14:48

richard-ramos requested a review from fryorcraken May 4, 2023 14:54

weboko approved these changes May 4, 2023

View reviewed changes

fryorcraken approved these changes May 5, 2023

View reviewed changes

richard-ramos added 2 commits May 8, 2023 18:02

feat: merkle root tracker

5fb127e

fix: code review

c6cb75f

richard-ramos force-pushed the identity-credentials branch from bc4e98b to c6cb75f Compare May 8, 2023 22:02

richard-ramos merged commit e52107d into master May 8, 2023

richard-ramos deleted the identity-credentials branch May 8, 2023 22:10

richard-ramos mentioned this pull request Sep 12, 2023

Slowness to generate proofs with recent zerokit versions #66

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: use identity credentials, and expose hash, bulk insert and delete members functions #58

feat: use identity credentials, and expose hash, bulk insert and delete members functions #58

richard-ramos commented Apr 28, 2023

richard-ramos commented May 1, 2023

rymnc commented May 2, 2023

richard-ramos commented May 2, 2023

richard-ramos commented May 2, 2023

richard-ramos commented May 4, 2023

weboko left a comment

fryorcraken left a comment

fryorcraken May 5, 2023

fryorcraken May 5, 2023

fryorcraken May 5, 2023

richard-ramos May 5, 2023

weboko May 5, 2023

fryorcraken May 5, 2023

weboko May 5, 2023

fryorcraken May 6, 2023

fryorcraken May 5, 2023

richard-ramos May 5, 2023

	#### Generating RLN membership credentials
	#### Generating RLN Membership Credentials

	let credentials = rlnInstance.generateIdentityCredentials();
	const credentials = rlnInstance.generateIdentityCredentials();

feat: use identity credentials, and expose hash, bulk insert and delete members functions #58

feat: use identity credentials, and expose hash, bulk insert and delete members functions #58

Conversation

richard-ramos commented Apr 28, 2023

richard-ramos commented May 1, 2023

rymnc commented May 2, 2023

richard-ramos commented May 2, 2023

richard-ramos commented May 2, 2023

richard-ramos commented May 4, 2023

weboko left a comment

Choose a reason for hiding this comment

fryorcraken left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment