Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slowness to generate proofs with recent zerokit versions #66

Open
richard-ramos opened this issue Sep 12, 2023 · 9 comments
Open

Slowness to generate proofs with recent zerokit versions #66

richard-ramos opened this issue Sep 12, 2023 · 9 comments
Labels
bug Something isn't working track:rln RLN Track (Secure Messaging/Applied ZK), e.g. relay and applications

Comments

@richard-ramos
Copy link
Member

As described in these comments:

@weboko
Copy link
Contributor

weboko commented Sep 14, 2023

My understanding is that in this issue we should:

  • investigate why it happens
  • mitigate on js side if possible

@richard-ramos is it correct?

@weboko weboko moved this to To Do in Waku Sep 14, 2023
@richard-ramos
Copy link
Member Author

Indeed, but i'm not entirely sure we'll be able to mitigate the issue on JS side as it seems to have been introduced in zerokit

@fryorcraken fryorcraken added E:3.2: Basic DoS protection in production See https://github.com/waku-org/pm/issues/70 for details bug Something isn't working and removed E:2023-rln labels Sep 22, 2023
@rymnc
Copy link

rymnc commented Oct 9, 2023

@tyshko-rostyslav any idea why this is happening?

@tyshko-rostyslav
Copy link

If indeed this commit vacp2p/zerokit@5eb98d4 is the reason, it's quite odd, nothing special is happening there

@rymnc
Copy link

rymnc commented Oct 9, 2023

@tyshko-rostyslav is it possible the move from ark-circom 0.3.0 to 0.4.0 is the problem?

@tyshko-rostyslav
Copy link

There was a significant slowdown, when we changed versions, specifically a lot of operations became compressed. As you've seen in this thread, I tried uncompressed versions in ark-circom 0.4, which somewhat helped, but not to the desired effect

@rymnc
Copy link

rymnc commented Oct 10, 2023

right, I think it'd be more performant if js-rln used a similar approach to https://github.com/Rate-Limiting-Nullifier/rlnjs, maybe even use the package to avoid de-duped work. ofcourse, they use rln-v2, but an older commit will be your best bet

@weboko
Copy link
Contributor

weboko commented Oct 27, 2023

I need to look into how we can leverage https://github.com/Rate-Limiting-Nullifier/rlnjs

@chair28980 chair28980 moved this from To Do to Priority in Waku Jan 4, 2024
@weboko weboko added track:rln RLN Track (Secure Messaging/Applied ZK), e.g. relay and applications and removed E:3.2: Basic DoS protection in production See https://github.com/waku-org/pm/issues/70 for details labels Jan 31, 2024
@weboko weboko moved this from Priority to Icebox in Waku Apr 24, 2024
@weboko
Copy link
Contributor

weboko commented Apr 24, 2024

rlnjs was not selected to be used due to fact that we needed to maintain proxy in JS code for our RLN contract and be able to optimize code in our own way.

Ice boxing this task as in future we might have a light weight way of generating / verifying proofs. Potentially we can use parts of rlnjs for this to avoid using wasm version of zerokit.

@adklempner @waku-org/js-waku-developers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working track:rln RLN Track (Secure Messaging/Applied ZK), e.g. relay and applications
Projects
Status: Icebox
Development

No branches or pull requests

5 participants