Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ListBlocks nested in StructBlocks #525

Merged
merged 2 commits into from
Feb 25, 2022
Merged

Conversation

zerolab
Copy link
Collaborator

@zerolab zerolab commented Feb 22, 2022

A continuation of #510, this adds support for ListBlock in StrucBlock and expands the test case for ListBlock in nested StreamBlock

@zerolab zerolab force-pushed the fix/nested-listblock branch from bae5e6a to 2f4b18a Compare February 22, 2022 22:05
@codecov-commenter
Copy link

codecov-commenter commented Feb 22, 2022

Codecov Report

Merging #525 (d380160) into main (e9e0ba9) will increase coverage by 0.00%.
The diff coverage is 89.47%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #525   +/-   ##
=======================================
  Coverage   91.62%   91.63%           
=======================================
  Files          37       37           
  Lines        3201     3214   +13     
  Branches      513      515    +2     
=======================================
+ Hits         2933     2945   +12     
  Misses        152      152           
- Partials      116      117    +1     
Impacted Files Coverage Δ
wagtail_localize/segments/extract.py 87.58% <85.71%> (-0.01%) ⬇️
wagtail_localize/test/models.py 97.46% <100.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9e0ba9...d380160. Read the comment docs.

@zerolab zerolab requested a review from kaedroho February 22, 2022 22:18
@zerolab zerolab force-pushed the fix/nested-listblock branch from 2f4b18a to e8fdd1b Compare February 22, 2022 23:22
@zerolab zerolab added this to the 1.1 milestone Feb 22, 2022
A common pattern that requires a tad more handling
Copy link
Contributor

@kaedroho kaedroho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thanks!

Do you think we would need to to a similar thing for list block in nested stream blocks too?

@zerolab
Copy link
Collaborator Author

zerolab commented Feb 24, 2022

Do you think we would need to to a similar thing for list block in nested stream blocks too?

78124cc has an example of/tests for a ListBlock in a StreamBlock. I did not try ListBlock in StructBlock in StreamBlock in StreamBlock though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants