Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for ListBlock #510

Merged
merged 2 commits into from
Feb 3, 2022
Merged

Add support for ListBlock #510

merged 2 commits into from
Feb 3, 2022

Conversation

zerolab
Copy link
Collaborator

@zerolab zerolab commented Jan 21, 2022 •
edited
Loading

Builds on #509 (as it needs Wagtail 2.16)

Fixes #22

@zerolab zerolab force-pushed the feature/handle-list-block branch 3 times, most recently from 1bc6c1d to 6ce2bb1 Compare January 21, 2022 22:19
@zerolab zerolab requested a review from kaedroho January 21, 2022 22:39
@zerolab zerolab force-pushed the feature/handle-list-block branch from 6ce2bb1 to 498a255 Compare January 26, 2022 14:48
kaedroho
kaedroho suggested changes Feb 1, 2022
View reviewed changes
Copy link
Contributor

@kaedroho kaedroho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me so far. I think we should add a check in to make sure that the blocks have IDs and not extract these

wagtail_localize/segments/extract.py Show resolved Hide resolved
@zerolab zerolab force-pushed the feature/handle-list-block branch from 498a255 to 6d130e5 Compare February 2, 2022 14:41
@zerolab zerolab requested a review from kaedroho February 2, 2022 14:42
@zerolab zerolab force-pushed the feature/handle-list-block branch from 6d130e5 to 5dd79d6 Compare February 2, 2022 15:52
kaedroho
kaedroho approved these changes Feb 3, 2022
View reviewed changes
Copy link
Contributor

@kaedroho kaedroho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thanks!

@zerolab zerolab merged commit 58d3231 into wagtail:main Feb 3, 2022
@zerolab zerolab deleted the feature/handle-list-block branch February 3, 2022 11:59
@zerolab zerolab added this to the 1.1 milestone Feb 3, 2022
@zerolab zerolab mentioned this pull request Feb 22, 2022
Merged
@zerolab zerolab mentioned this pull request Mar 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaedroho kaedroho kaedroho approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.

Translatable ListBlock
2 participants
@zerolab @kaedroho