Fix #175 - CWT contest - DxStation now sends 'R' after receiving report. #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Bob, @WR7Q I added you to this review so you could be exposed to a step we use during development called a code review. While I understand you are not a programmer, you will be able to understand the change being made to add the 'R' before the report is sent. When responding to a review, the reviewer will usually add a comment saying the approve of the review. To see the actual code change, click on the link "#175" above (see circle below)... I will handle the final merging step after one or more reviewers look at this code. Glad to have you on the team. 73, Mike |
ct7aup
approved these changes
Feb 4, 2023
|
Thanks! I'll do that.
73 Bob WR7Q
…On Sat, Feb 4, 2023, 03:44 ct7aup ***@***.***> wrote:
***@***.**** approved this pull request.
—
Reply to this email directly, view it on GitHub
<#176 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANIHTM2Q7G3G7SMX4QAEJFLWVYXHFANCNFSM6AAAAAAURA2SZY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
w7sst
deleted the
175-cwt-dxstation-should-send-r-after-users-exchange-is-sent
branch
w7sst
restored the
175-cwt-dxstation-should-send-r-after-users-exchange-is-sent
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #175. 'R' is now sent by DxStation after receiving user's callsign and name/MR to indicate message was received. This follows standard contest behaviors.