Amend PRR #2474
Merged
Amend PRR #2474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
admin-review
aurexav
force-pushed
the
master
branch
5 times, most recently
from
93f0bf1 to
c7d0e18
Compare
5 tasks
semuelle
requested changes
Dec 30, 2024
semuelle
added
the
changes requested
Signed-off-by: Xavier Lau <[email protected]>
keeganquigley
added
amendment
keeganquigley
previously approved these changes
Jan 6, 2025
semuelle
previously approved these changes
Jan 6, 2025
github-actions
bot
added
the
admin-review
keeganquigley
removed
the
admin-review
keeganquigley
approved these changes
Jan 7, 2025
takahser
approved these changes
Jan 7, 2025
Noc2
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After conducting some research, I realized the node tools is currently ineffective. More and more teams decide to release their runtimes separately. For example, Polkadot, Acala, Moonbeam and..
But I also worked on other tasks. Initially, I thought it would be beneficial to use subwasm and subwasmlib, but I discovered that the crate is overly complex and bloated with unnecessary dependencies. Additionally, its version management is poorly maintained (e.g., this issue has persisted unresolved for over a year).
As a result, I decided to develop my own version, which provides a streamlined subset of subwasm‘s functionality. The goal isn’t to replace subwasm entirely but to enhance the release process. Specifically, it aims to replace subwasm within the release pipeline. My implementation natively interacts with Docker in Rust, offers improved error handling compared to shell-based approaches, and inspects essential information from WASM files. This makes it a much more practical tool for the release pipeline.
Also, this tool comes with a specific customized Docker image for Polkadot-SDK-based runtime build maintained by hack-ink.
Consequently, I updated the deliverables by replacing the node tools with this new solution.
Link #2373.