Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deps Broken #47

Closed
aurexav opened this issue Jun 23, 2022 · 12 comments · Fixed by #67
Closed

Deps Broken #47

aurexav opened this issue Jun 23, 2022 · 12 comments · Fixed by #67

Comments

@aurexav
Copy link
Contributor

aurexav commented Jun 23, 2022

Fixed in #44
Re-introduced in 113e0af

@aurexav
Copy link
Contributor Author

aurexav commented Jun 23, 2022

error: failed to select a version for the requirement `jsonrpsee = "^0.13"`
candidate versions found which didn't match: 0.14.0
location searched: Git repository https://github.com/paritytech/jsonrpsee
required by package `wasm-loader v0.17.1 (https://github.com/chevdor/subwasm#ce5b6951)`
    ... which satisfies git dependency `wasm-loader` of package `runtime-overrides v0.1.0 (/root/Codes/darwinia-network/runtime-overrides)`

@aurexav
Copy link
Contributor Author

aurexav commented Jun 23, 2022

Please lock on tag or branch.
Otherwise, all the downstream packages will be broken.

@chevdor
Copy link
Owner

chevdor commented Jun 23, 2022

Did you build/run using --locked ?
I am aware of deps issues. I want to bring back all to substrate master.

@aurexav
Copy link
Contributor Author

aurexav commented Jun 23, 2022

Did you build/run using --locked ?
I am aware of deps issues. I want to bring back all to substrate master.

Nope. Just cargo update for my personal project.

@chevdor
Copy link
Owner

chevdor commented Jun 23, 2022

Ok, I'd suggest using --locked until this is fixed and avoid update the substrate related packages. I am aware of the issue.

@aurexav
Copy link
Contributor Author

aurexav commented Jun 23, 2022

Nope. My goal is to upgrade the subwasm I don't want to use --locked.

It's okay if you want to keep the latest upgrade with substrate.
I recommend you create a tag like substrate/cumulus/polkadot/parity-bridges-messags. polkadot-vx.x.x for the third party usage.

@chevdor
Copy link
Owner

chevdor commented Jul 4, 2022

The new version depends on ^0.14, that should solve your problem for now.

@chevdor chevdor closed this as completed Jul 4, 2022
@aurexav
Copy link
Contributor Author

aurexav commented Aug 3, 2022

Still not work.

error: failed to select a version for the requirement `jsonrpsee = "^0.14"`
candidate versions found which didn't match: 0.15.1
location searched: Git repository https://github.com/paritytech/jsonrpsee
required by package `wasm-loader v0.18.0 (https://github.com/chevdor/subwasm?tag=v0.18.0#f0ebe6db)`
    ... which satisfies git dependency `wasm-loader` of package `runtime-overrides v0.1.0 (/root/code/darwinia-network/runtime-overrides)`

I have to set up the target manually.

cargo update -p jsonrpsee --precise a26f1fb70913d59c2866ace97a24d5517f9769a3

@chevdor
Copy link
Owner

chevdor commented Aug 3, 2022

What command are you using ? I would like to see the issue on my end.

@aurexav
Copy link
Contributor Author

aurexav commented Aug 3, 2022

git clone https://github.com/darwinia-network/runtime-overrides.git
cd runtime-overrides
git checkout 4a51a7c05b85511927a79849392aa339364a812e
cargo update
# this will work, but I can not update other deps within a signle command
cargo update -p jsonrpsee --precise a26f1fb70913d59c2866ace97a24d5517f9769a3

@chevdor
Copy link
Owner

chevdor commented Aug 3, 2022

Thanks for the snippet, I can reproduce your issue.

@chevdor chevdor reopened this Aug 3, 2022
@aurexav
Copy link
Contributor Author

aurexav commented May 5, 2023

Sad. It can still be reproduced in 2023 with tag 0.19.1.

And the last update on crates.io is 2 years ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants