Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump jsonrpsee #44

Merged
merged 1 commit into from
Apr 9, 2022
Merged

Bump jsonrpsee #44

merged 1 commit into from
Apr 9, 2022

Conversation

aurexav
Copy link
Contributor

@aurexav aurexav commented Apr 6, 2022

paritytech/jsonrpsee#727

λ c update
    Updating crates.io index
    Updating git repository `https://github.com/chevdor/subwasm`
    Updating git repository `https://github.com/paritytech/jsonrpsee`
    Updating git repository `https://github.com/paritytech/substrate/`
error: failed to select a version for the requirement `jsonrpsee = "^0.9"`
candidate versions found which didn't match: 0.10.1
location searched: Git repository https://github.com/paritytech/jsonrpsee
required by package `wasm-loader v0.17.0 (https://github.com/chevdor/subwasm#045fdb4f)`
    ... which satisfies git dependency `wasm-loader` of package `runtime-overrides v0.1.0 (/root/Codes/darwinia-network/runtime-overrides)`

Suggest locking by tag. To prevent breaking downstream's cargo update.

@@ -11,7 +11,7 @@ version = "0.17.0"

[dependencies]
hex = "0.4"
jsonrpsee = {version = "0.9", git = "https://github.com/paritytech/jsonrpsee", features = ["full"]}
jsonrpsee = {version = "0.10.1", git = "https://github.com/paritytech/jsonrpsee", tag = "v0.10.1", features = ["full"]}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reduce the dependency tree a bit because the servers are not used :)

Suggested change
jsonrpsee = {version = "0.10.1", git = "https://github.com/paritytech/jsonrpsee", tag = "v0.10.1", features = ["full"]}
jsonrpsee = {version = "0.10.1", git = "https://github.com/paritytech/jsonrpsee", tag = "v0.10.1", features = ["client"]}

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will merge the PR as is and switch the client.

@chevdor
Copy link
Owner

chevdor commented Apr 9, 2022

Nice, thank you both !

@chevdor chevdor merged commit fbf37ec into chevdor:master Apr 9, 2022
@aurexav aurexav mentioned this pull request Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants