Update publickey-credentials to be "get-only" policy #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to WebAuthn issue #1336, the WebAuthn's "publickey-credentials" feature policy is renamed to "publickey-credentials-get", allowing only authentication (aka "getting an assertion") in cross-origin iframes. Credential creation is not allowed in cross-origin iframes, although it remains allowed by default (no feature-policy required) in same-origin-with-ancestors iframes. See also w3c/webauthn#1394, and https://w3c.github.io/webauthn/#sctn-feature-policy
blueboxd
pushed a commit
to blueboxd/chromium-legacy
that referenced
this pull request
May 1, 2020
The WebAuthn spec has removed the ability to allow cross-origin iframes to perform Web Authentication MakeCredential requests. This CL restricts it to just GetAssertion, and reflects the renamed Feature Policy. Feature Policy spec change: w3c/webappsec-permissions-policy#370 WebAuthn spec change: w3c/webauthn#1394 Bug: 993007 Change-Id: I9b5ccf05b5e39a5e5920b475111cdf797dcdb5a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120268 Reviewed-by: Martin Kreichgauer <[email protected]> Reviewed-by: Jeremy Roman <[email protected]> Reviewed-by: Ian Clelland <[email protected]> Commit-Queue: Ken Buchanan <[email protected]> Cr-Commit-Position: refs/heads/master@{#764743}
This was referenced May 4, 2020
Elchi3
pushed a commit
to mdn/browser-compat-data
that referenced
this pull request
May 6, 2020
Feature Policy directive controlling WebAuth was renamed from
publickey-credentials to publickey-credentials-get.
Sources:
Feature Policy change:
w3c/webappsec-permissions-policy#370
WebAuthn specification change:
w3c/webauthn#1394
Chrome already updated the name:
https://crbug.com/993007#c9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to WebAuthn issue w3c/webauthn#1336, the WebAuthn's "publickey-credentials" feature policy is renamed to "publickey-credentials-get", allowing only authentication (aka "getting an assertion") in cross-origin iframes. Credential creation is not allowed in cross-origin iframes, although it remains allowed by default (no feature-policy required) in same-origin-with-ancestors iframes.
See also PR w3c/webauthn#1394, and https://w3c.github.io/webauthn/#sctn-feature-policy