Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Feature Policy directive for WebAuthn #6085

Merged
merged 1 commit into from
May 6, 2020
Merged

Rename Feature Policy directive for WebAuthn #6085

merged 1 commit into from
May 6, 2020

Conversation

bershanskiy
Copy link
Contributor

Feature Policy directive controlling WebAuth was renamed from
publickey-credentials to publickey-credentials-get.
Sources:
Feature Policy change:
w3c/webappsec-permissions-policy#370
WebAuthn specification change:
w3c/webauthn#1394
Chrome already updated the name:
https://crbug.com/993007#c9

Fortunately, this directive wasn't shipped anywhere yet, so there is no actual compat data to be updated. Even Chromium bug number is still relevant.

Relevant sprint issue: mdn/sprints#3214

A checklist to help your pull request get merged faster:

  • Summarize your changes
  • Data: link to resources that verify support information (such as browser's docs, changelogs, source control, bug trackers, and tests)
  • Data: if you tested something, describe how you tested with details like browser and version
  • Review the results of the linter and fix problems reported (If you need help, please ask in a comment!)
  • Link to related issues or pull requests, if any

Feature Policy directive controlling WebAuth was renamed from
publickey-credentials to publickey-credentials-get.
Sources:
  Feature Policy change:
    w3c/webappsec-permissions-policy#370
  WebAuthn specification change:
    w3c/webauthn#1394
  Chrome already updated the name:
    https://crbug.com/993007#c9
@ghost ghost added the data:http 🚠 Compat data for HTTP features. https://developer.mozilla.org/docs/Web/HTTP label May 4, 2020
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I've moved the article as well. 👍

@Elchi3 Elchi3 merged commit f3b6776 into mdn:master May 6, 2020
@bershanskiy
Copy link
Contributor Author

Thanks, I closed mdn/sprints#3214 as well.

@bershanskiy bershanskiy deleted the fp-webauthn branch May 6, 2020 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:http 🚠 Compat data for HTTP features. https://developer.mozilla.org/docs/Web/HTTP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants