Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial update to target size (minimum) exceptions #3189

Merged
merged 6 commits into from
Nov 19, 2024

Conversation

patrickhlauke
Copy link
Member

@patrickhlauke patrickhlauke commented May 15, 2023

  • use "except when" to match the existing target size (enhanced) (rather than "except where")
  • structure the exceptions as definition list, in line with target size (enhanced) and all other cases in WCAG where we list things like this in normative SC wording
  • change the . full stop to a ; semicolon in the "Equivalent" description (as it's not the last definition) (already now addressed by [editorial fix] punctuation correction #2668)

See #3086 (comment)


Preview | Diff

* use "except when" to match the existing target size (enhanced)
* structure the exceptions as definition list, in line with target size (enhanced) and all other cases in WCAG where we list things like this in normative SC wording
* change the `.` full stop to a `;` semicolon in the "Equivalent" description (as it's not the last definition)
@mbgower
Copy link
Contributor

mbgower commented May 15, 2023

WCAG is very inconsistent with how it uses terminal punctuation in a list, but you have echoed the Chicago Manual's style. The definition lists give a bit of a curve ball, but I think this is an improvement on the prior version.

@patrickhlauke
Copy link
Member Author

WCAG is very inconsistent with how it uses terminal punctuation in a list, but you have echoed the Chicago Manual's style. The definition lists give a bit of a curve ball, but I think this is an improvement on the prior version.

the definition list way (which then also has ; and . on the last definition) is indeed very weird, but at least consistently weird with all other such uses in the existing WCAG 2.0/2.1 SCs, yeah

@patrickhlauke
Copy link
Member Author

@alastc @mbgower any chance this could get merged?

or is this whole section redundant anyway as it gets overridden?
@patrickhlauke patrickhlauke force-pushed the patrickhlauke-target-size-minimum-editorial branch from f40341e to c5663ec Compare July 20, 2023 08:53
@bruce-usab
Copy link
Contributor

Briefly discussed on TF call 4/12. Needs a volunteer to review.

Copy link
Contributor

@bruce-usab bruce-usab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Main change is from UL to DL.

@mbgower mbgower self-assigned this May 3, 2024
Copy link

netlify bot commented Oct 22, 2024

Deploy Preview for wcag2 ready!

Name Link
🔨 Latest commit 619cc42
🔍 Latest deploy log https://app.netlify.com/sites/wcag2/deploys/67178fa698840f0008e4f658
😎 Deploy Preview https://deploy-preview-3189--wcag2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kfranqueiro kfranqueiro merged commit ec1d270 into main Nov 19, 2024
5 checks passed
@kfranqueiro kfranqueiro deleted the patrickhlauke-target-size-minimum-editorial branch November 19, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants