Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aligning target size SCs #3097

Closed
wants to merge 1 commit into from
Closed

Conversation

alastc
Copy link
Contributor

@alastc alastc commented Mar 8, 2023

Closes #3086


Preview | Diff

@patrickhlauke
Copy link
Member

Thanks @alastc

the one aspect not covered by this PR is the last point though:

  • 2.5.8 has the following definition/exception: "Essential: A particular presentation of the target is essential or is legally required for the information being conveyed;"; 2.5.5 has "Essential: A particular presentation of the target is essential to the information being conveyed." ... so, is the "legally required" aspect of no concern for AAA ? And if so, why? Or just an oversight? (this leaves me with a weird "can't do AAA and be legal" feeling.

So is it intentional that you may potentially not be able to be legal and follow AAA?

@patrickhlauke
Copy link
Member

So is it intentional that you may potentially not be able to be legal and follow AAA?

@mbgower
Copy link
Contributor

mbgower commented Apr 3, 2023

essential or is legally required for the information being conveyed

nice catch. My recollection was that we were being explicit adding "legal" and that some felt it was redundant. But in for a penny.... Should be the same for both, I think?

<dt>Spacing:</dt>
<dd>The target does not overlap any other target and has a <a>target offset</a> of at least 24 CSS pixels to every adjacent target;</dd>
<dt>Equivalent:</dt>
<dd>The function can be achieved through a different control on the same page that meets this criterion.</dd>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change . at the end of this to ;

<dt>User agent control:</dt>
<dd>The size of the target is determined by the user agent and is not modified by the author;</dd>
<dt>Essential:</dt>
<dd>A particular presentation of the target is <a>essential</a> or is legally required for the information being conveyed;</dd>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change the ; at the end of this to .

@patrickhlauke
Copy link
Member

need to work out relationship with #3123

@bruce-usab
Copy link
Contributor

bruce-usab commented Apr 11, 2023

+1 for aligning Target Size SCs.

Exception for inline also needs updating at AAA -- for all the same reasons we worked so hard on AA inline exception.

I do not think we need Spacing exception at AAA.

From call today 4/11 , +1 to @WilcoFiers concern that definition of "Essential" for Target Size should not vary from essential exception used elsewhere. It should not be the case that "legal" is part of essential for this SC only.

@fstrr fstrr closed this May 28, 2024
@fstrr fstrr deleted the Issue3086-target-size-alignment branch May 28, 2024 20:51
@patrickhlauke
Copy link
Member

I would have actually liked this alignment of normative wording - but can't recall if we already have that again in another PR

@fstrr fstrr restored the Issue3086-target-size-alignment branch May 29, 2024 14:35
@fstrr
Copy link
Contributor

fstrr commented May 29, 2024

Re-opened and added to the project board as "in progress". Not sure if we have it in another PR—hopefully adding it to the board will generate a discussion around that.

@fstrr fstrr reopened this May 29, 2024
@patrickhlauke
Copy link
Member

Looking at this again, it seems that what this was doing (roughly anyway) was covered already by #3189 which is now waiting for CfC, so in hindsight it looks like it can be closed.

@kfranqueiro kfranqueiro deleted the Issue3086-target-size-alignment branch October 28, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Further alignment of structure/wording of 2.5.5 Target Size (Enhanced) and 2.5.8 Target Size (Minimum)
5 participants