Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update H39.html #2137

Merged
merged 6 commits into from
Jul 15, 2024
Merged

Update H39.html #2137

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9dd473c
Update H39.html
mbgower Nov 15, 2021
1110fbd
Update H39.html
mbgower Nov 15, 2021
2d336f9
Merge branch 'main' into H39-test-rewrite
patrickhlauke Jun 21, 2024
6925d46
Update techniques/html/H39.html
patrickhlauke Jun 21, 2024
4756602
Update techniques/html/H39.html
patrickhlauke Jun 21, 2024
67ed908
Update techniques/html/H39.html
fstrr Jun 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions techniques/html/H39.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,16 +27,15 @@ <h3>An appointment calendar with a <code class="el">caption</code>
</section>
</section><section id="tests"><h2>Tests</h2>
<section class="procedure"><h3>Procedure</h3>
<p>For each data table: </p>
<p>For each data table that has content that is presented as a title or identifier:</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe instead of indentifier, more like description? or perhaps having that in addition to identifier? just because i've seen folks use <caption> to provide something more like a summary/explanation for a table.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, expanding this PR further (to remind myself of the actual untouched content) I see that the "title or identifier" wording is actually in the main prose. while it goes beyond the scope of this PR, it might be worth tweaking it there too

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pushed commit to address. I was a little leery of using it since I didn't want to get into confusion over the old table summary attribute, but I agree 'description' is better.

<ol>
<li>Check that the table has content that is presented as a table caption.</li>
<li>Check that the table includes a <code class="el">caption</code> element.</li>
<li>Check that the content of the <code class="el">caption</code> element identifies the table.</li>
<li>Check that the text that titles or identifies the table is included in the <code class="el">caption</code> element.</li>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

depending on the above comment, this will then obviously also be affected

</ol>
</section>
<section class="results"><h3>Expected Results</h3>
<ul>
<li>#1-3 are true.</li>
<li>#1 and #2 are true.</li>
</ul>
</section>
</section><section id="related"><h2>Related Techniques</h2><ul>
Expand Down