-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update H39.html #2137
Update H39.html #2137
Conversation
Update to address #2136
techniques/html/H39.html
Outdated
@@ -27,16 +27,15 @@ <h3>An appointment calendar with a <code class="el">caption</code> | |||
</section> | |||
</section><section id="tests"><h2>Tests</h2> | |||
<section class="procedure"><h3>Procedure</h3> | |||
<p>For each data table: </p> | |||
<p>For each data table that has content that is presented as a title or identifier:</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe instead of indentifier
, more like description
? or perhaps having that in addition to identifier
? just because i've seen folks use <caption>
to provide something more like a summary/explanation for a table.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, expanding this PR further (to remind myself of the actual untouched content) I see that the "title or identifier" wording is actually in the main prose. while it goes beyond the scope of this PR, it might be worth tweaking it there too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pushed commit to address. I was a little leery of using it since I didn't want to get into confusion over the old table summary attribute, but I agree 'description' is better.
techniques/html/H39.html
Outdated
<li>Check that the table includes a <code class="el">caption</code> element.</li> | ||
<li>Check that the content of the <code class="el">caption</code> element identifies the table.</li> | ||
<li>Check that the text that titles or identifies the table is included in the <code class="el">caption</code> element.</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
depending on the above comment, this will then obviously also be affected
Addresses @patrickhlauke's comments
i'd reopen and make ve this forward |
I understand the first two words, but the rest have lost me :) |
sorry...pool+phone+autocorrect don't make it easy ;) |
fixed it up to resolve the merge conflict |
closes #2136 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See inline comment.
I'm not sure that this solves the mis-conception about whether captions are required, but I thought the top of the description (old and new) already did so. No harm from the change. Could folks give this a thumbs up for it to get merged... |
Update to address #2136
Tighten the language of H39 Using caption elements to associate data table captions with data tables to isolate it to only passing 1.3.1 Info and Relationships: