Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update H39.html #2137

Merged
merged 6 commits into from
Jul 15, 2024
Merged

Update H39.html #2137

merged 6 commits into from
Jul 15, 2024

Conversation

mbgower
Copy link
Contributor

@mbgower mbgower commented Nov 15, 2021

Update to address #2136
Tighten the language of H39 Using caption elements to associate data table captions with data tables to isolate it to only passing 1.3.1 Info and Relationships:

  1. if there is a visible text title/caption for the table, then
  2. make sure it is referenced so that the title/caption is programmaticalyy associated.

Update to address #2136
@@ -27,16 +27,15 @@ <h3>An appointment calendar with a <code class="el">caption</code>
</section>
</section><section id="tests"><h2>Tests</h2>
<section class="procedure"><h3>Procedure</h3>
<p>For each data table: </p>
<p>For each data table that has content that is presented as a title or identifier:</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe instead of indentifier, more like description? or perhaps having that in addition to identifier? just because i've seen folks use <caption> to provide something more like a summary/explanation for a table.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, expanding this PR further (to remind myself of the actual untouched content) I see that the "title or identifier" wording is actually in the main prose. while it goes beyond the scope of this PR, it might be worth tweaking it there too

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pushed commit to address. I was a little leery of using it since I didn't want to get into confusion over the old table summary attribute, but I agree 'description' is better.

<li>Check that the table includes a <code class="el">caption</code> element.</li>
<li>Check that the content of the <code class="el">caption</code> element identifies the table.</li>
<li>Check that the text that titles or identifies the table is included in the <code class="el">caption</code> element.</li>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

depending on the above comment, this will then obviously also be affected

Addresses @patrickhlauke's comments
@patrickhlauke
Copy link
Member

i'd reopen and make ve this forward

@fstrr fstrr restored the H39-test-rewrite branch May 29, 2024 16:02
@fstrr
Copy link
Contributor

fstrr commented May 29, 2024

i'd reopen and make ve this forward

I understand the first two words, but the rest have lost me :)

@fstrr fstrr reopened this May 29, 2024
@patrickhlauke
Copy link
Member

i'd reopen and make ve this forward

I understand the first two words, but the rest have lost me :)

sorry...pool+phone+autocorrect don't make it easy ;)

@patrickhlauke
Copy link
Member

fixed it up to resolve the merge conflict

@patrickhlauke patrickhlauke self-assigned this Jun 21, 2024
@bruce-usab
Copy link
Contributor

closes #2136

techniques/html/H39.html Outdated Show resolved Hide resolved
Copy link
Contributor

@detlevhfischer detlevhfischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comment.

techniques/html/H39.html Show resolved Hide resolved
@alastc
Copy link
Contributor

alastc commented Jul 12, 2024

I'm not sure that this solves the mis-conception about whether captions are required, but I thought the top of the description (old and new) already did so. No harm from the change.

Could folks give this a thumbs up for it to get merged...

@mbgower mbgower merged commit 9a291c9 into main Jul 15, 2024
1 check passed
@mbgower mbgower deleted the H39-test-rewrite branch July 15, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

H39 Using caption elements to associate data table captions with data tables needs a rewritten test
6 participants