Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.5.3 - control with label but no accname (understanding note + new failure technique) #2057

Merged
merged 14 commits into from
Mar 11, 2024

Conversation

patrickhlauke
Copy link
Member

@patrickhlauke patrickhlauke commented Sep 25, 2021

Also cleans-up 2.5.3 understanding document markup/structure

  • adds new F111 Control with visible label text but no accname (improperly numbered F109 initially)
  • add failure technique in Understanding document
  • added notes in Understanding about UI components with visible text and no name failing both 4.1.2 and 2.5.3
  • removed direct reference to WCAG 2.1
  • resolved discussion with ACT on where to report some of the failure examples

Closes #2045

- add the note about UI components with visible text and no name, which fail both 4.1.2 and 2.5.3
- edit link to 1.3.5 to remove the hardcoded reference to WCAG 2.1
@mraccess77
Copy link

Thanks @patrickhlauke looks good to me.

@detlevhfischer
Copy link
Contributor

Looks good to me too.

@jake-abma
Copy link
Contributor

+1

@patrickhlauke
Copy link
Member Author

Any news on this @alastc ?

avoids merge conflicts due to new failure techniques that appeared since the PR was made
@patrickhlauke
Copy link
Member Author

Just resolved the merge conflict (caused by more recent failure techniques that were added in the time since this PR was first filed), so this is ready to merge again...

@awkawk
Copy link
Member

awkawk commented Sep 6, 2023

I don't think that checks 2 or 3 are needed for this.

@patrickhlauke
Copy link
Member Author

@awkawk you made me look a the test procedure again, and on reflection I actually modified the procedure to be more specific. have a look

@bruce-usab
Copy link
Contributor

On deck for 1/26 call.

@bruce-usab
Copy link
Contributor

Preview link for F111.html

Copy link
Member

@scottaohara scottaohara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

marking as approve with my minor editorial updates

techniques/failures/F111.html Outdated Show resolved Hide resolved
techniques/failures/F111.html Outdated Show resolved Hide resolved
techniques/failures/F111.html Outdated Show resolved Hide resolved
techniques/failures/F111.html Outdated Show resolved Hide resolved
Copy link
Contributor

@dbjorge dbjorge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Missing an update to the Failure Techniques section of label-in-name.html to reference the new technique?
  2. If we do retitle to note applicability to 1.3.1 and/or 4.1.2, consider also adding a ref to those understanding docs' Failure Techniques sections?

techniques/failures/F111.html Outdated Show resolved Hide resolved
techniques/failures/F111.html Outdated Show resolved Hide resolved
@patrickhlauke
Copy link
Member Author

Added the failure technique to the 2.5.3 understanding doc (forgot to do it earlier). While I was there, also corrected the understanding document, which was/is in a shockingly broken state (with actual live input/labels as part of the understanding, when they should be code samples, and a misnesting of sections/headings).

@patrickhlauke
Copy link
Member Author

@alastc question: should I also add the technique to 1.3.1 and 4.1.2? I held off it at the time, because I wasn't sure if doing so would cause issues if the 1.3.1/4.1.2 understanding docs are also still used for WCAG 2.0 and 2.1. if not, I'm happy to also add the technique to the respective understanding docs (and tidy them a tiny bit) in this PR

@patrickhlauke patrickhlauke force-pushed the patrickhlauke-issue2045 branch 2 times, most recently from f4e06c4 to 6967424 Compare March 9, 2024 15:29
@patrickhlauke patrickhlauke force-pushed the patrickhlauke-issue2045 branch from 6967424 to c4a37d6 Compare March 9, 2024 15:30
@alastc alastc dismissed stale reviews from dbjorge and WilcoFiers March 11, 2024 16:22

Patrick made updates based on the review.

@alastc alastc merged commit 6fc9553 into main Mar 11, 2024
1 check passed
@patrickhlauke
Copy link
Member Author

@alastc so as you merged this, assume the answer to my question above is: no, don't add the failure technique to 1.3.1 and 4.1.2

@patrickhlauke patrickhlauke deleted the patrickhlauke-issue2045 branch September 8, 2024 10:16
patrickhlauke added a commit that referenced this pull request Sep 8, 2024
patrickhlauke added a commit that referenced this pull request Sep 8, 2024
mbgower pushed a commit that referenced this pull request Oct 29, 2024
Follow-up to
#2057 (comment)

Co-authored-by: Kenneth G. Franqueiro <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does SC 2.5.3 fail when there is a visual text label but the control has no accessible name?