Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update act-rules-format.md for mapping secondary accessibility requirements #531
Update act-rules-format.md for mapping secondary accessibility requirements #531
Changes from 1 commit
d06205a
ae658ba
5c8814d
ca118f3
faca230
c6a0bcd
3a42ca5
8aab815
4dc257e
4149fc8
94e3ddb
1edfa96
d78ced1
50e6f96
ad065fa
428c777
62ad17a
3d83ed9
7850c84
c6604c6
3321f8f
f1d4051
c2cb8bd
b59f9c5
ca1fde0
0463d8a
a54100d
6b3314e
d1c0d9e
9518e6d
052858c
1852468
46152cc
f268da2
a3fdbc7
e701f60
6da8df5
83cfcfb
2e1418c
be78cdb
6173784
e6af050
639b64b
47b5c37
9aeb2e7
40d3449
fb80828
0f6dea9
b6ec42b
17350fe
ed0f372
6fb98a9
0124152
c9b2608
6b9c187
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this impacts implementations, I don't think this can be optional. There could be no secondary requirements for a rule, but I think if there are success criteria that sometimes fail, they have to be listed. Otherwise what should be consistent implementations won't be.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this may need to be flipped. Atomic rules do not have a relationship with composite rules. I.e. you could in theory add a composite rule without updating the atomic rule. I think this requirement should be flipped, in that a composite rule must not include accessibility requirements unless they are part of all its atomic rules. I.e. the compisite rule has the exact same accessibility requirements as its atomic rules. The main difference being that what is secondary and what is not will differ.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From how I am reading it, lines 248 and 251 are saying the same thing: an atomic rule cannot map to something that the composite rule does not map to.
In 248 I read it as the atomic rule must map to a (possibly improper) subset of the composite rule's mapping. And in 251, I read it as the composite rule must map to the union of all of the mappings (conformance and secondary) present in the atomic rules.
So I'm not sure it needs to be flipped, but some clarification might be helpful.