Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Testing locally section in README.md. #10

Merged
merged 2 commits into from
Jan 2, 2024
Merged

Update Testing locally section in README.md. #10

merged 2 commits into from
Jan 2, 2024

Conversation

JSAssassin
Copy link
Contributor

No description provided.

BigBlueHat
BigBlueHat requested changes Jan 2, 2024
View reviewed changes
Copy link
Member

@BigBlueHat BigBlueHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also make sure .gitignore gets updated.

README.md Outdated
localImplementationsConfig.cjs
```
If you want to test your implementations for endpoints running locally, you can
create a configuration file `localImplementationsConfig.cjs` in the root
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need a . prefix? The text here and in the similar CCG repo w3c-ccg/vc-test-suite-implementations#98 mention them both with and without the ., so we should clarify that both places--one way or the other.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, fixed here 4057386.

@JSAssassin
Copy link
Contributor Author

We should also make sure .gitignore gets updated.

@BigBlueHat Do you mean we should add .localImplementationsConfig.cjs to .gitignore file in various test suites or are you suggesting we should update the .gitignore file here?

@BigBlueHat
Copy link
Member

@BigBlueHat Do you mean we should add .localImplementationsConfig.cjs to .gitignore file in various test suites or are you suggesting we should update the .gitignore file here?

Oof...yeah. It'd have to be loads of places... Let's leave it out for now, but we an add it if folks start to send PRs with it--or if we're
doing other non-code updates to things like readmes, etc. Let's leave it alone for now. Thanks!

@JSAssassin JSAssassin merged commit 5807d38 into main Jan 2, 2024
2 checks passed
@JSAssassin JSAssassin deleted the update-testing-locally-section branch January 2, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BigBlueHat BigBlueHat BigBlueHat approved these changes

@aljones15 aljones15 Awaiting requested review from aljones15

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JSAssassin @BigBlueHat