Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename .vcApiTestImplementationsConfig.cjs to .localImplementationsConfig.cjs. #98

Merged
merged 3 commits into from
Jan 2, 2024

Conversation

JSAssassin
Copy link
Contributor

No description provided.

`localImplementationsConfig.cjs`.
Copy link
Contributor

@BigBlueHat BigBlueHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Naming is hard, but this one is definitely better!

Copy link
Contributor

@BigBlueHat BigBlueHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change, actually.

CHANGELOG.md Outdated

### Changed
- **BREAKING**: Rename `vcApiTestImplementationsConfig.cjs` config for testing
localhost implementations to `localImplementationsConfig.cjs`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These both need . prefixes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BigBlueHat Good catch, thanks! Fixed here 6d1fae3

@JSAssassin JSAssassin changed the title Rename vcApiTestImplementationsConfig.cjs to localImplementationsConfig.cjs. Rename .vcApiTestImplementationsConfig.cjs to .localImplementationsConfig.cjs. Jan 2, 2024
@JSAssassin JSAssassin merged commit 1315ab6 into main Jan 2, 2024
2 checks passed
@JSAssassin JSAssassin deleted the update-localhost-config-name branch January 2, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants