Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added table border css to charclass class #132

Merged
merged 4 commits into from
Nov 26, 2019
Merged

Conversation

himorin
Copy link
Contributor

@himorin himorin commented Nov 8, 2019

for #101

@xfq
Copy link
Member

xfq commented Nov 10, 2019

For preview, see Appendix A.x in raw.githack.com, or download the zip file of the branch and open index.html.

Current version (for comparison): https://w3c.github.io/jlreq/#opening-brackets-cl-01-cl-01

@r12a
Copy link
Contributor

r12a commented Nov 11, 2019

i think it would look better with the following applied to all the td & th elements:

vertical-align: top;
padding: .1em .25em;

@himorin
Copy link
Contributor Author

himorin commented Nov 15, 2019

Added. For padding, already have 0 .5em, so added numbers (results as sum).
It seems fine for character class tables, but glossary has p-wrapped words for definition (long description line), and it seems somehow strange spacing... How about to apply vertical-align only for character class tables?

@r12a
Copy link
Contributor

r12a commented Nov 15, 2019

I didn't expect you to add the numbers, just replace existing code with the code i provided. So that's maybe why it looks odd to you. I experimented with various padding amounts before choosing that one.

@himorin
Copy link
Contributor Author

himorin commented Nov 15, 2019

Ah, sorry for that. and updated by 0de8e84.
But,,, following display in Terminology seems irregular for me...
image

@r12a
Copy link
Contributor

r12a commented Nov 15, 2019

I agree. That's caused by the style rule in base.css on line 383 that says

margin: 1cm 0;

You can override that in these tables with a rule at the bottom of local.css that says:

.termlist p { margin: 0 0 1em 0; }

Does that look better?

(Btw, i noticed that the description for Mincho typeface is broken Japanese splits the english.)

@himorin
Copy link
Contributor Author

himorin commented Nov 26, 2019

Thank you for suggestion, and I've also tried several more (like adding margin: 0 for p:last-child without adding anything to js), but gave up to remove space at the bottom...
let me go with current (090bbb8) one.

@r12a r12a merged commit 5481c83 into w3c:gh-pages Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants