Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add table borders to ones in Appendix A #101

Closed
himorin opened this issue Jul 8, 2019 · 4 comments
Closed

Add table borders to ones in Appendix A #101

himorin opened this issue Jul 8, 2019 · 4 comments
Labels
jlreq-doc:errata [JLReq-doc] errata fix items for 2nd edition

Comments

@himorin
Copy link
Contributor

himorin commented Jul 8, 2019

from item 4. in #99 (comment)
There are several tables in Appendix A for classes of characters, we had border in 2nd ed. but not for now.

@himorin
Copy link
Contributor Author

himorin commented Sep 6, 2019

better to share css definitions with termlist to charclass, will open PR after PR #99 merged.

@himorin himorin added the jlreq-doc:errata [JLReq-doc] errata fix items for 2nd edition label Nov 13, 2019
@kidayasuo
Copy link
Contributor

@r12a This reminds me of need for a pre-release testing. Is there a standard process, or how is it usually done?

@himorin
Copy link
Contributor Author

himorin commented Nov 26, 2019

closing per #132 merged.
@kidayasuo shall I file new issue for pre-release testing, or continue email conversation?

@himorin himorin closed this as completed Nov 26, 2019
@kidayasuo
Copy link
Contributor

Yes, please file a new issue. As this revision got structural changes in addition to relatively simple errata fixes, I believe we need more testing.
What are standard practices? also I wonder how it was done on the first version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jlreq-doc:errata [JLReq-doc] errata fix items for 2nd edition
Projects
None yet
Development

No branches or pull requests

2 participants