Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-release tasks for JLReq errata update #141

Closed
himorin opened this issue Nov 27, 2019 · 20 comments
Closed

Pre-release tasks for JLReq errata update #141

himorin opened this issue Nov 27, 2019 · 20 comments

Comments

@himorin
Copy link
Contributor

himorin commented Nov 27, 2019

from #101, comment by @kidayasuo

Yes, please file a new issue. As this revision got structural changes in addition to relatively simple errata fixes, I believe we need more testing.
What are standard practices? also I wonder how it was done on the first version.

We need to develop list of required checks to be performed, and go through these checks.

@kidayasuo
Copy link
Contributor

Do you know if there are standard process of testing in w3c? if there is no such thing probably we (TFReq TF members) each would take a look by comparing pre- and post- update side by side.

@himorin
Copy link
Contributor Author

himorin commented Nov 27, 2019

Usually htmldiff is used for comparison, but I don't think it will work for this our case...

@kidayasuo
Copy link
Contributor

I agree. what we need to test is visual and probably comparing the source is not very effective for that purpose.

@r12a
Copy link
Contributor

r12a commented Nov 27, 2019

There are, of course, other tests we run before creating a WD in the w3.org/TR space, which include:

  • check for valid HTML
  • check for valid CSS
  • check all links work
  • check conformance with pubrules

Hopefully, people editing the ED always ensure that the result of their commits is valid HTML and that the links work.

However, there is no existing procedure that i'm aware of for checking visual appearance of the document other than due diligence by the editor.

@kidayasuo
Copy link
Contributor

Thank you Richard.
@himorin Were the four tests Richard mentioned run on the update?

@himorin
Copy link
Contributor Author

himorin commented Nov 28, 2019

For side-by-side test, I wandered there is any easy way to check word-by-word comparison, with using several text tools like grep/sed/diff, but almost giving up to build a set of way: such that we switched to use respec that introduces automatic generation of links (but not using a element in document) and it changes text within a line.
I'll try to check side-by-side overview comparison and also in composed format again (like recently found mixed lines in terminology section).

For generic(?) tests, I did tests with locally generated ready-to-go document set at https://jlreq-old.ksw.himor.in/2019-jlreq/

  • HTML validator: no error/warning except for bdi and composing character
  • CSS validator: valid
  • pubrules note two errors (except html validator above) and two warnings
    • (error) title and h1 mismatch: what to do for this kind of composed format?
    • (error) patent policy paragraph not found: but it actually exists,,,
    • (warning) wrapping section number by class="secno"
    • (warning) add back-to-top hyperlink at the end
  • link checker found no error

@kidayasuo
Copy link
Contributor

Thank you for running all the tests.

As for the pub rules errors, what is the nature of the "title and h1 mismatch" error? I guess the patent policy error can be ignored as we actually have one. Do you think we can safely ignore the warnings?

As for visual check, how about we jlreq member share the responsibility and each take a portion of the document? The focus will be on the formatting, such as charts, indentation, position of graphics x etc. and will be done on English only and Japanese only pages. What do you think?

@himorin
Copy link
Contributor Author

himorin commented Dec 2, 2019

I've (roughly) gone through 'all' mode for checking inconsistency or divided sentences like one in #139, and found followings:

@himorin
Copy link
Contributor Author

himorin commented Dec 2, 2019

As for the pub rules errors, what is the nature of the "title and h1 mismatch" error? I guess the patent policy error can be ignored as we actually have one. Do you think we can safely ignore the warnings?

I found adding one U+20 could remove warning. Let me push PR shortly.

As for visual check, how about we jlreq member share the responsibility and each take a portion of the document? The focus will be on the formatting, such as charts, indentation, position of graphics x etc. and will be done on English only and Japanese only pages. What do you think?

That could be an option, or I may take some part (or to-where-I-can-finish) and proceed from now before next F2F?

@kidayasuo
Copy link
Contributor

That could be an option, or I may take some part (or to-where-I-can-finish) and proceed from now before next F2F?

sure. that is great. thank you so much.

@xfq
Copy link
Member

xfq commented Dec 3, 2019

(error) patent policy paragraph not found: but it actually exists,,,

I think the document in https://jlreq-old.ksw.himor.in/2019-jlreq/ lacks the "W3C maintains a public list of any patent disclosures..." text, as you can see in the Status of This Document of clreq. I'm not sure why, though, since we do have the wgPatentURI option in jlreq's respecConfig.

@kidayasuo
Copy link
Contributor

Is #149 the only remaining open issue?

@himorin
Copy link
Contributor Author

himorin commented Dec 12, 2019

Is #149 the only remaining open issue?

I assume 'yes'.

@himorin
Copy link
Contributor Author

himorin commented Jun 9, 2020

for now, following one error is reported (with local update on specStatus, previousPublishDate, previousMaturity) from pubrules, html, css, link:

  • two id="w3c_process_revision", this is from adding Japanese text for SoTD, and I'd propose to remove id in Japanese version.

@kidayasuo
Copy link
Contributor

do we know how to solve it?

@himorin
Copy link
Contributor Author

himorin commented Jun 11, 2020

per discussion with @kidayasuo , pushed PR #216 for this

* two id="w3c_process_revision", this is from adding Japanese text for SoTD, and I'd propose to remove id in Japanese version.

@himorin
Copy link
Contributor Author

himorin commented Jun 11, 2020

will re-check and close this shortly.

@kidayasuo
Copy link
Contributor

Are there any remaining tasks? Let’s finish this up. #140 is a maintenance work and does not block the release.

@himorin
Copy link
Contributor Author

himorin commented Jul 16, 2020

Checked pubrules,css,html,link on current HEAD with following change, found two link errors:
(test files at: https://storage.himor.in/jlreq-20200716/Overview.html )

         specStatus: "WD",
         previousPublishDate:  "2012-04-03",
         previousMaturity:  "WG-NOTE",

Link errors were link to 'index.html?lang=xx'. I'll push PR to fix.

@himorin
Copy link
Contributor Author

himorin commented Jan 5, 2021

closing this, new NOTE had been published.

@himorin himorin closed this as completed Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants