Fix regressions in the JSON report #1499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`CheckingReport`. `XmlReportImpl`, and `XmpReportImpl` are all used to produce a formatted report to a file or output stream. This commit unifies their constructor API to receive a `PrintWriter` instance. Previously, only the latter two did, while `CheckingReport` was constructed with a path to the report file.
The report used for tests (`TestReport`) can now generate a formatted report. - a new `setReportingFormat(String)` method is used to set the generated report format (can be "JSON", "XML", "XMP", or defaulting to a silent report) - the `initialize()` method (Report API) is used to instantiate a delegate formatting report - the `generate()` method (Report API) is used to finalize the formatted report delegate - a new `getOutput()` method is used to retrieve a String containing the formatted report This formatting functionality is exposed as a cucumber step implemented in `TestConfiguration` and called with (in this example, for a JSON report): ``` Given the reporting format is set to JSON ```
Add the following Cucumber steps:
- `Then the JSON report is valid`
- `Then JSON at {string} contains {int} items`
- `Then JSON at {string} has no null values`
- `Then JSON at {string} is not null`
- `Then JSON at {string} is {string}`
JSON values or arrays are inspected using expressions based on a JSON path DSL,
and asserted with the [json-path-assert](https://github.com/json-path/JsonPath) library.
This was caused by a regression after the refactoring of the parsing of the container structure and package documents. This commit adds a new feature file to write tests for the JSON report. The first test scenarios check basic assertions: - JSON is well-formed - the items array has the correct number of items (no items duplication) - the checksum field Fix #1475, Fix #1490
This was
linked to
issues
Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.