Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect "item" JSON output for epubcheck 5.0.0 #1475

Closed
nekennedy opened this issue Jan 17, 2023 · 1 comment · Fixed by #1499
Closed

Incorrect "item" JSON output for epubcheck 5.0.0 #1475

nekennedy opened this issue Jan 17, 2023 · 1 comment · Fixed by #1499
Assignees
Labels
priority: medium To be processed and published in one of the upcoming releases status: has PR The issue is being processed in a pull request type: bug The issue describes a bug
Milestone

Comments

@nekennedy
Copy link

We are seeing some substantial differences for the "item" json. Everything is coming through as "null", 0, or false in epubcheck 5.0.0. Additionally, there are sometimes two entries for each asset (I haven't confirmed this duplication is true for all asset types in all situations).

json output for a single html page from epubcheck 4.2.6:

{
    "id" : "acknowledgements",
    "fileName" : "OEBPS/acknowledgements.xhtml",
    "media_type" : "application/xhtml+xml",
    "compressedSize" : 1123,
    "uncompressedSize" : 2108,
    "compressionMethod" : "Deflated",
    "checkSum" : "cf72435894dc21d72e528e95ab44f916646d05b661e66a7b0b61a8eda97aa77",
    "isSpineItem" : true,
    "spineIndex" : 24,
    "isLinear" : true,
    "navigationOrder" : 23,
    "isHTML5" : true,
    "isFixedFormat" : false,
    "isScripted" : false,
    "scriptSrc" : false,
    "scriptTag" : false,
    "scriptInline" : false,
    "renditionLayout" : "reflowable",
    "renditionOrientation" : "auto",
    "renditionSpread" : "auto",
    "referencedItems" : [ "OEBPS/content-toc.xhtml", "OEBPS/styles/custom.css" ]
  }

epubcheck 5.0.0 output for that same file, which has two entries:

{
    "id" : "acknowledgements",
    "fileName" : "acknowledgements.xhtml",
    "media_type" : null,
    "compressedSize" : 0,
    "uncompressedSize" : 0,
    "compressionMethod" : null,
    "checkSum" : null,
    "isSpineItem" : false,
    "spineIndex" : null,
    "isLinear" : false,
    "navigationOrder" : null,
    "isHTML5" : false,
    "isFixedFormat" : null,
    "isScripted" : false,
    "scriptSrc" : false,
    "scriptTag" : false,
    "scriptInline" : false,
    "renditionLayout" : null,
    "renditionOrientation" : null,
    "renditionSpread" : null,
    "referencedItems" : [ ]
  }
  **[...]**
  {
    "id" : "ePubCheck.NoManifestRef:OEBPS/acknowledgements.xhtml",
    "fileName" : "OEBPS/acknowledgements.xhtml",
    "media_type" : "application/xhtml+xml",
    "compressedSize" : 0,
    "uncompressedSize" : 0,
    "compressionMethod" : null,
    "checkSum" : null,
    "isSpineItem" : true,
    "spineIndex" : 24,
    "isLinear" : true,
    "navigationOrder" : null,
    "isHTML5" : false,
    "isFixedFormat" : false,
    "isScripted" : false,
    "scriptSrc" : false,
    "scriptTag" : false,
    "scriptInline" : false,
    "renditionLayout" : "reflowable",
    "renditionOrientation" : "auto",
    "renditionSpread" : "auto",
    "referencedItems" : [ ]
  }

From an impact perspective, we (PRH) or not use the json output in any of our ebook production tools. We are using the json output for out EAA backlist project, but not the individual "item" json. I thought it was worth reporting since others may be using this output.

@rdeltour rdeltour self-assigned this Jan 19, 2023
@rdeltour rdeltour added type: bug The issue describes a bug status: accepted Ready to be further processed priority: medium To be processed and published in one of the upcoming releases labels Jan 19, 2023
@rdeltour rdeltour added this to the Next maintenance release milestone Jan 19, 2023
@rdeltour
Copy link
Member

Ah good catch, thanks for the report @nekennedy!

@rdeltour rdeltour linked a pull request Apr 28, 2023 that will close this issue
@rdeltour rdeltour added status: has PR The issue is being processed in a pull request and removed status: accepted Ready to be further processed labels Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: medium To be processed and published in one of the upcoming releases status: has PR The issue is being processed in a pull request type: bug The issue describes a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants