Some editorial changes following PR 1898 #1927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Closed
Closed
dlazin
reviewed
Nov 22, 2021
| @@ -475,7 +475,7 @@ <h3>Manifest</h3> | |||
| id="confreq-rs-pkg-manifest-unknown" data-tests="#pkg-manifest-unknown">Reading Systems MUST | |||
| ignore values of the <code>properties</code> attribute they do not recognize.</span></p> | |||
|
|
|||
| <p id="confreq-rendition-rs-manifest" data-tests="#pkg-manifest-unlisted-resource">It SHOULD NOT use | |||
| <p id="confreq-rendition-rs-manifest" data-tests="#pkg-manifest-unlisted-resource">Reading Systems SHOULD NOT use | |||
There was a problem hiding this comment.
Were lines 1268-86 supposed to be committed?
There was a problem hiding this comment.
I do not understand your question @dlazin
dlazin
approved these changes
Nov 22, 2021
rdeltour
suggested changes
Nov 23, 2021
There was a problem hiding this comment.
I'm suggesting making the changes suggested by @mattgarrish to close #1919.
Other than that looks OK to me!
rdeltour
approved these changes
Nov 23, 2021
mattgarrish
reviewed
Nov 23, 2021
Closed
mattgarrish
approved these changes
Nov 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are issues found by @mattgarrish.
It fixes #1923 and #1924.
It also fixes the editorial comment of #1919 (comment), but the closure of #1919 shouldn't be done automatically by merging this PR.
Finally, there was an invalid cross-reference to a parsing section.
See:
Preview | Diff