-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Declarative alternative to the file path definition #1919
Comments
I assume you mean this section: https://www.w3.org/TR/epub-33/#sec-file-names-to-path-names ? I agree it feels out of place, but I'm not sure it's critical to rewrite. I'd opt for clarity over form, but if you can write an equivalent declaratively that's easier to read I wouldn't object. I find the introductory sentence kind of confusing in the way it uses "file" twice, though (three times if you count "File Path"):
I had to read a few times to parse out the meaning. Is it necessary to drop the variable in before the algorithm, or could this be more like:
|
The original issue may become moot soon. Indeed, the WG has agreed with the fundamental question in #1912, and the proposed changes follow the same "algorithmic" approach. I would think we should close this issue (modulo the editorial remarks of @mattgarrish). |
Agreed. Actually, the change is even simpler; there is no need for the variable |
Just noting that the obfuscation algorithm has pseudo-code that is similar to this, too. It's formatted as an example right now (which is wrong). |
O.k., that then makes the original issue moot. Should I add this as an automatically-closeable issue with #1927? |
Introducing the algorithm parameters in the declaration is recommended by Infra. I'd stick to this form if possible? |
Sure, but what confused me is that it's hard to figure out that's what's going on. There isn't an obvious name for the algorithm and there isn't a "given" to introduce the variable, just a lot of "file"s to read through. It would still be clearer if it were formatted like:
|
Currently, the File Path term is defined in a separate section in an algorithmic fashion, which makes this a bit different from the rest of the document that favours declarative definitions. The question is whether there is a good alternative for the definition that would replace the algorithmic section.
@mattgarrish @rdeltour
The text was updated successfully, but these errors were encountered: