Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds an internationalization section #33

Merged
merged 3 commits into from
Jun 20, 2019

Conversation

fallaciousreasoning
Copy link
Collaborator

@fallaciousreasoning fallaciousreasoning commented Jun 19, 2019

Adds a note on how user agents should format badge values.

Note: I think we should probably update the spec with this note too, but I'm not sure on the standard procedure?

See #23 for context.


Preview | Diff

Copy link

@raymeskhoury raymeskhoury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should just be added to the spec rather than the explainer?

@fallaciousreasoning
Copy link
Collaborator Author

Added it to the spec.

index.html Outdated
@@ -136,6 +136,10 @@ <h2>
user agent MAY ignore the data, and merely show a marker when the
status is <a>set</a>.
</p>
<p>
When presenting a badge, it SHOULD be formatted according to the user's
locale settings.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add an example?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added.

@fallaciousreasoning fallaciousreasoning merged commit 2c73924 into master Jun 20, 2019
@fallaciousreasoning fallaciousreasoning deleted the internationalization branch June 20, 2019 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants