Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add internationalization section #23

Closed
marcoscaceres opened this issue May 21, 2019 · 2 comments
Closed

Add internationalization section #23

marcoscaceres opened this issue May 21, 2019 · 2 comments

Comments

@marcoscaceres
Copy link
Member

The API allows set()ting unsigned long long types. Presumedly, when the badge is presented, these would then be formatted appropriately based on the user's locale settings.

We should add a note about this...
@fallaciousreasoning fallaciousreasoning mentioned this issue Jun 19, 2019
Merged
@fallaciousreasoning
Copy link
Collaborator

fallaciousreasoning commented Jun 19, 2019 •
edited
Loading

Do we need to explicitly note this in the spec? #33 adds it to the explainer. Sorry, I'm pretty new to spec work.

@fallaciousreasoning
Copy link
Collaborator

I’ve added a brief paragraph with an example to the spec.

@marcoscaceres marcoscaceres mentioned this issue May 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@marcoscaceres @fallaciousreasoning