-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add info about layout and bounds to generic #1207
Conversation
…ric and presentation
Very nice, @mcking65 ! I made a few tiny editorial changes to your changes:
@jnurthen We should probably merge #1142 before merging this? It deletes the editor's note about triage of global properties, and makes |
@jnurthen @joanmarie @mcking65 This PR is ready for final review. The only changes are to the prose for generic role, and I have already incorporated Matt's editorial suggestions. Here's the preview. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
R+ BUT I did mention some nits that I'd like addressed (or at least considered).
- add "for use as the implicit role..." clause - lowercase "user agents" - remove excess commas - change "a generic" to "an element with role generic"
@jnurthen Ready for final review. pr-preview is timing out (I ran it a few times - will try again later), but here is the updated generic role prose after addressing @cookiecrook and @joanmarie's comments:
|
@jnurthen ping - build is passing and pr-preview is good. |
* Revise to highlight difference in authoring requirements between generic and presentation Co-authored-by: Matt King <[email protected]>
* Revise to highlight difference in authoring requirements between generic and presentation Co-authored-by: Matt King <[email protected]>
Resolves #1182.
Preview | Diff