Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add info about layout and bounds to generic #1207

Merged
merged 5 commits into from
Mar 26, 2020
Merged

Add info about layout and bounds to generic #1207

merged 5 commits into from
Mar 26, 2020

Conversation

carmacleod
Copy link
Contributor

@carmacleod carmacleod commented Feb 27, 2020

Resolves #1182.


Preview | Diff

@carmacleod
Copy link
Contributor Author

Very nice, @mcking65 !
I like having the most important info (i.e. "authors should not use generic") up front.
Also, "like presentation" and "unlike presentation" helps keep the generic vs presentation statements separate.
This is much more coherent now.

I made a few tiny editorial changes to your changes:

  • added "or none" after the first instance of "presentation" (felt like it needed to be there)
  • changed "a variety of other named containers such as group" to "a semantic container role such as group" because "named containers" and "named container" were in the same sentence and it felt redundant
  • added "that" in "so that assistive technologies can..."

@jnurthen We should probably merge #1142 before merging this? It deletes the editor's note about triage of global properties, and makes aria-roledescription prohibited on generic (further differentiating generic from presentation).

@carmacleod
Copy link
Contributor Author

@jnurthen @joanmarie @mcking65

This PR is ready for final review. The only changes are to the prose for generic role, and I have already incorporated Matt's editorial suggestions.

Here's the preview.

@jnurthen jnurthen requested a review from cookiecrook March 5, 2020 18:23
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
Copy link
Contributor

@joanmarie joanmarie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

R+ BUT I did mention some nits that I'd like addressed (or at least considered).

- add "for use as the implicit role..." clause
- lowercase "user agents"
- remove excess commas
- change "a generic" to "an element with role generic"
@carmacleod
Copy link
Contributor Author

carmacleod commented Mar 10, 2020

@jnurthen Ready for final review.

pr-preview is timing out (I ran it a few times - will try again later), but here is the updated generic role prose after addressing @cookiecrook and @joanmarie's comments:

A nameless container element that has no semantic meaning on its own.

The generic role is intended for use as the implicit role of generic elements in host languages (such as HTML div or span), so is primarily for implementors of user agents. Authors SHOULD NOT use this role in content. Authors MAY use presentation or none to remove implicit accessibility semantics, or a semantic container role such as group to semantically group descendants in a named container.

Like an element with role presentation, an element with role generic can provide a limited number of accessible states and properties for its descendants, such as aria-live attributes. However, unlike elements with role presentation, generic elements are exposed in accessibility APIs so that assistive technologies can gather certain properties such as layout and bounds.

@carmacleod
Copy link
Contributor Author

@jnurthen ping - build is passing and pr-preview is good.
Quick! Review this before something else breaks! 😄

@jnurthen jnurthen merged commit d1a4d25 into master Mar 26, 2020
jnurthen pushed a commit that referenced this pull request Mar 26, 2020
* Revise to highlight difference in authoring requirements between generic and presentation
Co-authored-by: Matt King <[email protected]>
carmacleod added a commit that referenced this pull request May 7, 2020
* Revise to highlight difference in authoring requirements between generic and presentation
Co-authored-by: Matt King <[email protected]>
@jnurthen jnurthen deleted the issue1182 branch July 23, 2020 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Concerning the "generic" role
5 participants