-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prohibit aria-roledescription from role=generic #1142
Conversation
|
👍 (But it's less of a problem since the spec says that UAs must not expose aria-brailleroledescription if there's no valid aria-roledescription.) |
agreed, though still not a bad idea to be explicit :) making a commit to add this now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 (with or without note)
@scottaohara Can you please remove the commit prohibiting brailleroledescription on generic from this PR. I can't merge that to the 1.2 branch (which is the desire for this) as we won't have brailleroledescription there. We can ask @pkra to add that to #1097 |
@jnurthen removed it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have an open question:
Do we want to add a prohibition on user agents exposing aria-roledescription if it is set on a generic? Currently prohibited only says Authors MUST NOT - it has no restriction on user agents (and we want to keep it that way). On the other hand aria-roledescription could have this prohibition in the 2nd bulleted list by adding a 3rd bullet:
"User agents MUST NOT expose the aria-roledescription property if any of the following conditions exist:
- The element to which aria-roledescription is applied does not have a valid WAI-ARIA role or does not have an implicit WAI-ARIA role semantic.
- The value of aria-roledescription is empty or contains only whitespace characters.
- aria-roledescription is prohibited on the explicit or implicit WAI-ARIA role."
(please wordsmith as appropriate)
Attempted wordsmithing of 3rd point, above:
...and make it the 2nd point instead? |
I think it is important to have this UA restriction language in roledescription before merging:
|
if prohibited
@scottaohara pushed a change - can you take a look |
i think that looks good, thank you @jnurthen, sorry i didn't get to adding it sooner. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
closes #1140, pending answering comment about note
Preview | Diff