-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Infrastructure: Update vnu-jar parameters to remove unused paths #2617
Conversation
The warnings I now get when running this are:
|
Going back through the history, the only new (and blocking) error here is: |
Seems like there is still an issue with the problem matcher for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good Howard, and as for the error you're seeing, I tested removing the p tag inside the summary tag and it didn't have any adverse effects and visually looks and behaves identically, so I think removing it would be a good resolution to that error.
Unfortunate. Seems similar to what's being tracked in #2082 |
Thanks for taking a look @alflennik. I updated |
e0ba7b8
to
f64a834
Compare
This build is now passing following #2640 merge |
This looks good to me. Should I merge? I'm wondering if it is possible to modify
We don't want to suppress those warnings globally, just for those files. |
f64a834
to
e911b75
Compare
It doesn't seem like this is possible. The path information doesn't seem to be included in what the regex is being written against in validator/validator#1044 also requested this as a feature and the author has since marked it as an upcoming enhancement.
Sure! Unless we want to reconsider globally supressing those warnings for now and tracking it in an issue? |
See #2637
Update the path used with
vnu-jar
tocontent
.WAI Preview Link failed to build on 'Update site files' step. (Last tried on Wed, 21 Jun 2023 14:18:40 GMT).