Infrastructure: Bump ava and selenium-webdriver
#2640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
howard-e
added
Infrastructure
4 tasks
mcking65
reviewed
Mar 7, 2023
| @@ -35,6 +35,7 @@ jobs: | |||
| - name: Set up Node.js | |||
| uses: actions/setup-node@v3 | |||
| with: | |||
| node-version: 16 | |||
There was a problem hiding this comment.
If this line is intended to be temporary, do we have an issue tracking the underlying issue that will remind us to remove this line?
There was a problem hiding this comment.
I've renamed #2636 to be more specific to this issue so we can continue tracking there.
This was referenced Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2636.
Bump
avaandselenium-webdriver.Also temporarily pin the node version to
v16when executing theRun regression testsjob.actions/setup-node@v3has recently defaulted to usingv18but that it seems to break the regression tests running in CI in this repository.This should be temporary because we'd ideally want to solve what's happening for the latest node LTS version here.
WAI Preview Link (Last built on Thu, 02 Mar 2023 21:58:20 GMT).