Add "use strict" and lint rule #1416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nschonni
approved these changes
Jun 2, 2020
spectranaut
force-pushed
the
1379-strict-mode
branch
2 times, most recently
from
d1a5fd4 to
fe4e848
Compare
spectranaut
force-pushed
the
1379-strict-mode
branch
from
fe4e848 to
33883b7
Compare
spectranaut
force-pushed
the
1379-strict-mode
branch
from
33883b7 to
227ef34
Compare
spectranaut
approved these changes
Jun 25, 2020
There was a problem hiding this comment.
The tests were failing because not all of the "undeclared" variables were fixed in PR #1370. They were caught by the regression tests -- nice to see our tests catching bugs! :)
To look for more undeclared vars (perhaps in a code path not covered by the regression tests) I added "no-undef" to the linter -- but it will be a lot of work to get this to pass because of all the global variables in the example javascript code. I opened a PR to start that work: #1429
michael-n-cooper
pushed a commit
that referenced
this pull request
Jun 25, 2020
All Examples: Add "use strict" and lint rule (pull #1416) * add strict mode and fix all errors * fix linting errors * Fix menubar * Declare undeclared variables in tabs Co-authored-by: Valerie Young <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1379