Use local index variables for loops

[pepelsbey]

Here’s my story:

I took tabs.js file from the tabs implementation and it worked just fine… Until I transpiled it with babel/preset-env and minified with terser. This is a typical thing to do with any modern JS code.

"use strict";!function(){var e,t,n=document…

Babel adds "use strict"; by default and this is what broke it for me. Turns out there are for loops using global index variables:

for (i = 0; i < tabs.length; ++i) {
    addListeners(i);
}

Which works fine until you add "use strict";.

I went through all the sample JS code and added var in front of every index variable (not defined previously) to make it compatible with the strict mode.

Also there are some trailing spaces are gone according to your EditorConfig, sorry about that. I could probably revert that and keep only var in this PR.

[mcking65]

The file: common/script/aria.js
is from the w3c/aria-common repo.

If you'd like to suggest changes for that file, please submit a PR there. However, that file should not have any effect on anything you are doing with APG.

Please revert the changes to this file.

[pepelsbey]

Done: reverted aria.js

[zcorpan]

I wonder if we should add "use strict" everywhere, and enforce it with a lint check. I can report an issue to discuss it.

[zcorpan]

#1379

[zcorpan]

Also there are some trailing spaces are gone according to your EditorConfig, sorry about that.

I think that's OK, and I wonder why that happens. I suppose some contributors use editors that don't apply the EditorConfig. Maybe this should be enforced with a lint check, too? #1380

[mcking65]

@zcorpan, I see your approval so I assume this is good to go now?

@jongund, just a heads up that we'll be merging this, and it will have a very small effect on 2 of your PRs.

[zcorpan]

@mcking65 Yes, this is ok to merge.

[smhigley]

There's one more place where the changes re-declare a variable. With that fixed, this looks good to me.