Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review new Read Me First section #482

Closed
3 tasks done
mcking65 opened this issue Oct 15, 2017 · 10 comments
Closed
3 tasks done

Review new Read Me First section #482

mcking65 opened this issue Oct 15, 2017 · 10 comments
Assignees

Comments

@mcking65
Copy link
Contributor

mcking65 commented Oct 15, 2017

A proposed draft of a new
Read Me First
section is ready for review. This addresses issue #474, and adds statements regarding browser and assistive technology support and mobile/touch compatibility.

Task Force Reviews Requested as of October 15, 2017

@devarshipant
Copy link

Consider - http://w3c.github.io/aria-practices/#no_aria_better_bad_aria and the para "Using a role without fulfilling the promise of that role is similar to making a "Place Order" button that abandons an order and empties the shopping cart."

I think the analogy will be more easily understood when the example code <div role="button">Press Me</div> reflects some part of the analogy.

@mcking65
Copy link
Contributor Author

@devarshipant, could that be achieved with a change as simple as changing:

<div role="button">Press Me</div>

To:

<div role="button">Place Order</div>

Or, did you have something else in mind?

@devarshipant
Copy link

Yes, that change connects the two pieces. Thank you!

@annabbott
Copy link

Reviewed and found no changes needed, aside from the one mentioned by @devarshipant .

mcking65 added a commit that referenced this issue Oct 22, 2017
Made change to button label suggested by @devarshipant in issue #482.
@devarshipant
Copy link

A few suggestions:

  1. Code example - <a aria-label="Assistive tech users perceive this aria-label, not the link text">Link Text</a> should be:
    <a aria-label="Assistive tech users perceive this as a label, not the link text">Link Text</a>

  2. Users could get overwhelmed trying to seek more information sorrounding ARIA, APIs, etc. on their own. I think there should be references (or helpful bits in this section) to understand where and how ARIA fits in the grand scheme of things by mentioning or referencing:

@accdc
Copy link

accdc commented Oct 27, 2017

This section looks good to me, though I'd recommend changing the following:

"Functionally, ARIA roles, states, and properties are sort of like CSS for assistive technologies."

To the following instead:

"Functionally, ARIA roles, states, and properties are analogous to CSS for assistive technologies."

@LaurenceRLewis
Copy link

Although the word analogous is perfectly suited — I believe many users won’t understand or relate to it. Therefore I recommend changing to: “...properties are comparable with css ...”

mcking65 added a commit that referenced this issue Oct 28, 2017
Based on feedback from @accdc and @devarshipant in issue #482,
modified aria-practices.html:
* Wording of comparison of CSS and ARIA
* aria-label content for example link code
* Label of toggle button code
@mcking65
Copy link
Contributor Author

mcking65 commented Oct 28, 2017

@devarshipant commented:

<a aria-label="Assistive tech users perceive this aria-label, not the link text">Link Text</a>

should be:

 <a aria-label="Assistive tech users perceive this as a label, not the link text">Link Text</a>

Kind of ... it is not just that aria-label is a label, but that it is the only thing that is perceivable because it wipes out acccess to the link text. I made a change in commit 0ef198f that hopefully makes that more clear.

Users could get overwhelmed trying to seek more information sorrounding ARIA, APIs, etc. on their own. I think there should be references (or helpful bits in this section) to understand where and how ARIA fits in the grand scheme of things by mentioning or referencing:
Relationship between DOM, Accessibility Tree, and Accessible Object ( https://www.w3.org/TR/core-aam-1.1/#intro_treetypes)
It’s relationship with accessibility APIs ( https://www.w3.org/TR/core-aam-1.1/#accessible-names-and-descriptions)
General rules of exposing ARIA semantics ( https://www.w3.org/TR/core-aam-1.1/#mapping_general)
Role mapping and how Assistive Technology interprets the table at https://www.w3.org/TR/core-aam-1.1/#mapping_role_table

We could definitely help people navigate the documents that serve as the basis for the practices. And, with issue #84, we plan to add an appendix on the background of ARIA. These kind of references could be part of that or in another appendix related to it.

this section is intentially void of links to avoid rabbit holes that might distract people from reading all the way through. My hope is to give people the bare-bones, not-so-obvious, information needed to use the guide successfully.

@mcking65
Copy link
Contributor Author

Thank you @accdc and @Decrepidos for the feedback.

I like the suggestion to explicitly state that I am making an analogy between CSS and ARIA. And, I modified the following sentence to strengthen the meaning in the event that the first sentence is not well comprehended.

Changes made in commit 0ef198f.

@mcking65
Copy link
Contributor Author

Thank you all for the feedback. Marking this as complete.

mcking65 added a commit that referenced this issue Oct 30, 2017
Modified Read Me First section of aria-practices.html:
Remove link to review issue #482.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants