-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review new Read Me First section #482
Comments
Consider - http://w3c.github.io/aria-practices/#no_aria_better_bad_aria and the para "Using a role without fulfilling the promise of that role is similar to making a "Place Order" button that abandons an order and empties the shopping cart." I think the analogy will be more easily understood when the example code |
@devarshipant, could that be achieved with a change as simple as changing:
To:
Or, did you have something else in mind? |
Yes, that change connects the two pieces. Thank you! |
Reviewed and found no changes needed, aside from the one mentioned by @devarshipant . |
Made change to button label suggested by @devarshipant in issue #482.
A few suggestions:
|
This section looks good to me, though I'd recommend changing the following: "Functionally, ARIA roles, states, and properties are sort of like CSS for assistive technologies." To the following instead: "Functionally, ARIA roles, states, and properties are analogous to CSS for assistive technologies." |
Although the word analogous is perfectly suited — I believe many users won’t understand or relate to it. Therefore I recommend changing to: “...properties are comparable with css ...” |
Based on feedback from @accdc and @devarshipant in issue #482, modified aria-practices.html: * Wording of comparison of CSS and ARIA * aria-label content for example link code * Label of toggle button code
@devarshipant commented:
Kind of ... it is not just that aria-label is a label, but that it is the only thing that is perceivable because it wipes out acccess to the link text. I made a change in commit 0ef198f that hopefully makes that more clear.
We could definitely help people navigate the documents that serve as the basis for the practices. And, with issue #84, we plan to add an appendix on the background of ARIA. These kind of references could be part of that or in another appendix related to it. this section is intentially void of links to avoid rabbit holes that might distract people from reading all the way through. My hope is to give people the bare-bones, not-so-obvious, information needed to use the guide successfully. |
Thank you @accdc and @Decrepidos for the feedback. I like the suggestion to explicitly state that I am making an analogy between CSS and ARIA. And, I modified the following sentence to strengthen the meaning in the event that the first sentence is not well comprehended. Changes made in commit 0ef198f. |
Thank you all for the feedback. Marking this as complete. |
Modified Read Me First section of aria-practices.html: Remove link to review issue #482.
A proposed draft of a new
Read Me First
section is ready for review. This addresses issue #474, and adds statements regarding browser and assistive technology support and mobile/touch compatibility.
Task Force Reviews Requested as of October 15, 2017
The text was updated successfully, but these errors were encountered: